Skip to content

Commit e0e7db4

Browse files
Fix typo. Add TPM support for keyring password.
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
1 parent b2dabfa commit e0e7db4

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/KNXBindingConstants.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
public class KNXBindingConstants {
3434

3535
public static final String BINDING_ID = "knx";
36-
public static final String ENCYRPTED_PASSWORD_SERIALIZATION_PREFIX = "TpM2-pRoTeCteD-";
36+
public static final String ENCRYPTED_PASSWORD_SERIALIZATION_PREFIX = "TpM2-pRoTeCteD-";
3737

3838
// Global config
3939
public static final String CONFIG_DISABLE_UOM = "disableUoM";

bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/config/BridgeConfiguration.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,15 @@ public String getKeyringFile() {
6363
}
6464

6565
public String getKeyringPassword() {
66-
return keyringPassword;
66+
return decrypt(keyringPassword);
6767
}
6868

6969
protected String decrypt(String secret) {
70-
if (secret.startsWith(KNXBindingConstants.ENCYRPTED_PASSWORD_SERIALIZATION_PREFIX)) {
70+
if (secret.startsWith(KNXBindingConstants.ENCRYPTED_PASSWORD_SERIALIZATION_PREFIX)) {
7171
try {
7272
logger.info("trying to access TPM module");
7373
return TpmInterface.TPM.deserializeAndDecryptSecret(
74-
secret.substring(KNXBindingConstants.ENCYRPTED_PASSWORD_SERIALIZATION_PREFIX.length()));
74+
secret.substring(KNXBindingConstants.ENCRYPTED_PASSWORD_SERIALIZATION_PREFIX.length()));
7575
} catch (SecurityException e) {
7676
logger.error("Unable to decode stored password using TPM: {}", e.getMessage());
7777
// fall through

bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/console/KNXCommandExtension.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public void execute(String[] args, Console console) {
8686
}
8787
String p = TpmInterface.TPM.encryptAndSerializeSecret(args[1]);
8888
console.println("encrypted representation of password");
89-
console.println(KNXBindingConstants.ENCYRPTED_PASSWORD_SERIALIZATION_PREFIX + p);
89+
console.println(KNXBindingConstants.ENCRYPTED_PASSWORD_SERIALIZATION_PREFIX + p);
9090

9191
// check if TPM can decrypt
9292
String decrypted = TpmInterface.TPM.deserializeAndDecryptSecret(p);

0 commit comments

Comments
 (0)