Skip to content

Commit 2ddd309

Browse files
authored
MediaScriptScopeProvider: Minor code enhancement (#5246)
Signed-off-by: Florian Hotze <[email protected]>
1 parent 448fe65 commit 2ddd309

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

bundles/org.openhab.core.automation.module.media/src/main/java/org/openhab/core/automation/module/media/internal/MediaScriptScopeProvider.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,34 +34,38 @@
3434
@NonNullByDefault
3535
public class MediaScriptScopeProvider implements ScriptExtensionProvider {
3636

37+
private static final String MEDIA_PRESET_NAME = "media";
38+
private static final String AUDIO_MANAGER_NAME = "audio";
39+
private static final String VOICE_MANAGER_NAME = "voice";
40+
3741
private final Map<String, Object> elements = new HashMap<>();
3842

3943
@Reference
4044
protected void setAudioManager(AudioManager audioManager) {
41-
elements.put("audio", audioManager);
45+
elements.put(AUDIO_MANAGER_NAME, audioManager);
4246
}
4347

4448
protected void unsetAudioManager(AudioManager audioManager) {
45-
elements.remove("audio");
49+
elements.remove(AUDIO_MANAGER_NAME);
4650
}
4751

4852
@Reference
4953
protected void setVoiceManager(VoiceManager voiceManager) {
50-
elements.put("voice", voiceManager);
54+
elements.put(VOICE_MANAGER_NAME, voiceManager);
5155
}
5256

5357
protected void unsetVoiceManager(VoiceManager voiceManager) {
54-
elements.remove("voice");
58+
elements.remove(VOICE_MANAGER_NAME);
5559
}
5660

5761
@Override
5862
public Collection<String> getDefaultPresets() {
59-
return Set.of("media");
63+
return Set.of(MEDIA_PRESET_NAME);
6064
}
6165

6266
@Override
6367
public Collection<String> getPresets() {
64-
return Set.of("media");
68+
return Set.of(MEDIA_PRESET_NAME);
6569
}
6670

6771
@Override

0 commit comments

Comments
 (0)