TypeParser and OnOffType

[falmanna]

I was debugging a NullPointerException returned from TypeParser.parseCommand function when I tried to parse a command string of value "1" for a SwitchItem item. I found that the OnOffType doesn't have a valueOf method and it is relying on the Enum.valueOf to parse string commands. That means only "ON" and "OFF" strings will be parsed.

Although the OnOffType has a from method that accepts a string of "1", it seems to never get called anywhere. So, was it supposed to be valueOf instead? or is it removed from this type intentionally?

I propose a change to the method from to be valueOf, and to add a third option to parse "true" to "ON"
So, this will become this:

public static OnOffType valueOf(String state) {
        return from("ON".equalsIgnoreCase(state) || "1".equalsIgnoreCase(state) || "true".equalsIgnoreCase(state));
}

[falmanna]

Ops, I forgot that valueOf cannot be overridden. I think this is not a bug but a missing feature that wasn't utilized.

[falmanna]

One way to implement this is to modify the parseCommand method and make it call the "from" method for OnOffType.
Seems like this same topic has been discussed in #1348 but was closed without a resolution. I will leave this issue open to hear from the core maintainers how should I address this, otherwise feel free to close it.