conditionhandler uid core.TimeOfDayCondition is inconsistent with triggerhandler uid timer.TimeOfDayTrigger

[jimtng]

One is core. and the other is timer.

It seems that core.TimeOfDayCondition should be timer.TimeOfDayCondition. However, changing this would break existing rules, but we can fix that in 5.x UpgradeTool for managed rules.

• Is this actually an inconsistency, or was there a reason for it to be core.TimeOfDayCondition instead of timer.TimeOfDayCondition?
• My guess is that core.TimeOfDayCondition was there first, then later on, along came timer.TimeOfDayTrigger, and timer.DayOfWeekCondition.
• In MainUI rule wizard, the TimeOfDayCondition is grouped with "Time Conditions" but when showing all conditions, it got grouped with "Core"
• Should we "fix" this or just leave it be?