NPE in OAuthClientServiceImpl

[cweitkamp]

I faced an NPE while installing a new automation addon.

2025-10-03 18:52:48.349 [WARN ] [mmon.WrappedScheduledExecutorService] - Scheduled runnable ended with an exception: java.lang.NullPointerException: Cannot invoke "org.openhab.core.auth.oauth2client.internal.OAuthStoreHandler.saveAccessTokenResponse(String, org.openhab.core.auth.client.oauth2.AccessTokenResponse)" because "this.storeHandler" is null
	at org.openhab.core.auth.oauth2client.internal.OAuthClientServiceImpl.getAccessTokenByResourceOwnerPasswordCredentials(OAuthClientServiceImpl.java:264) ~[?:?]
	at org.openhab.binding.worxlandroid.internal.handler.WorxLandroidBridgeHandler.initiateConnection(WorxLandroidBridgeHandler.java:99) ~[?:?]
	at org.openhab.binding.worxlandroid.internal.handler.WorxLandroidBridgeHandler.lambda$0(WorxLandroidBridgeHandler.java:93) ~[?:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:?]
	at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) ~[?:?]
	at java.lang.Thread.run(Unknown Source) [?:?]

The annotation seems to be a problem:

openhab-core/bundles/org.openhab.core.auth.oauth2client/src/main/java/org/openhab/core/auth/oauth2client/internal/OAuthClientServiceImpl.java

Line 71 in 3ed9b08

private @NonNullByDefault({}) OAuthStoreHandler storeHandler;

because the variable storeHandler is set to null during close process.

openhab-core/bundles/org.openhab.core.auth.oauth2client/src/main/java/org/openhab/core/auth/oauth2client/internal/OAuthClientServiceImpl.java

Lines 419 to 421 in 3ed9b08

	public void close() {
	closed = true;
	storeHandler = null;