DSL is generated incorrectly for bridges

[jlaur]

Bridges are generated as "Thing" rather than "Bridge".

Expected Behavior

Bridge miele:xgw3000:Miele_XGW3000 [ipAddress="192.168.0.252"]

Current Behavior

Example output for a Miele Gateway:

Thing miele:xgw3000:Miele_XGW3000 [ipAddress="192.168.0.252"]

For YAML, the output is correct:

version: 1
things:
  miele:xgw3000:Miele_XGW3000:
    isBridge: true
    config:
      ipAddress: 192.168.0.252

Possible Solution

Steps to Reproduce (for Bugs)

Discover a bridge, select "Copy Thing File Definition" and select "DSL".

Context

Your Environment

• Version used: 5.1
• Environment name and version (e.g. Chrome 111, Java 17, Node.js 18.15, ...):
• Operating System and version (desktop or mobile, Windows 11, Raspbian Bullseye, ...):

[jlaur]

FYI @lolodomo as you have fixed similar issues in the past.

[lolodomo]

This is not wrong, "Bridge" is required only if the thing has childs.
I remember I spent time on that case but I do not remember now why it was not possible to generate "Bridge". It might an automatic choice done by the generator when there is no child. But I will check again.

[jlaur]

This is not wrong, "Bridge" is required only if the thing has childs.

Sorry, then it's not a bug, only inconvenient. The problem is that when copying the DSL syntax from the UI from a newly discovered bridge, it will never have childs, since it by definition doesn't exist yet. Then, when later copying DSL for the childs and putting it all together, it's very easy to miss that it's "Thing" rather than "Bridge".