Skip to content

Commit 2e45fa7

Browse files
committed
fix channel getLinks
1 parent bc583d5 commit 2e45fa7

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

src/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
__version__ = "1.0.13" # version string is for backward compatibility with openhab 5.0.0
1+
__version__ = "1.0.14" # version string is for backward compatibility with openhab 5.0.0
22

33
from openhab.helper import rule, logger, Registry

src/helper.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -322,8 +322,9 @@ def getChannelLinks(self) -> list[Java_ItemChannelLink]:
322322

323323
@_Tracing.javacall
324324
def linkChannel(self, channel_uid: str, link_config: dict[str, str] = {}) -> Java_ItemChannelLink:
325-
link = Java_ItemChannelLink(self.getName(), Java_ChannelUID(channel_uid), Configuration(link_config))
326-
links = ITEM_CHANNEL_LINK_REGISTRY.getLinks(channel_uid)
325+
uid = Java_ChannelUID(channel_uid)
326+
link = Java_ItemChannelLink(self.getName(), uid, Configuration(link_config))
327+
links = ITEM_CHANNEL_LINK_REGISTRY.getLinks(uid)
327328
if len(links) > 0:
328329
if not links[0].getConfiguration().equals(link.getConfiguration()):
329330
ITEM_CHANNEL_LINK_REGISTRY.update(link)
@@ -333,9 +334,10 @@ def linkChannel(self, channel_uid: str, link_config: dict[str, str] = {}) -> Jav
333334

334335
@_Tracing.javacall
335336
def unlinkChannel(self, channel_uid: str) -> Java_ItemChannelLink:
336-
links = [l for l in self.getLinks() if l.getLinkedUID().getAsString() == channel_uid]
337+
uid = Java_ChannelUID(channel_uid)
338+
links = ITEM_CHANNEL_LINK_REGISTRY.getLinks(uid)
337339
if len(links) > 0:
338-
ITEM_CHANNEL_LINK_REGISTRY.remove(links[0].getUID())
340+
ITEM_CHANNEL_LINK_REGISTRY.remove(uid)
339341
return links[0]
340342
raise NotFoundException("Link {} not found".format(channel_uid))
341343

0 commit comments

Comments
 (0)