Firmware version is not provided correctly by Legrand devices in the initialization stage

[pgaufillet]

It looks Legrand with Netatmo devices don't provide the firmware version during initialisation as expected.
It would be nice to gracefully cope with this behaviour, for exemple by adding the following provision in ZigBeeThingHandler.otaIncomingRequest(QueryNextImageCommand command)

    @Override
    public ZigBeeOtaFile otaIncomingRequest(QueryNextImageCommand command) {
        // We simply store the requested firmware version information so that it's
        // available for the firmware provider
        lastFirmwareVersion = new ZigBeeFirmwareVersion(command.getManufacturerCode(), command.getImageType(),
                command.getFileVersion());

        // Some devices (e.g. Legrand) only report their firmware version in this request.
        // We can use this to update the thing property.
        String newFirmwareVersion = String.format("%s%08X", ZigBeeBindingConstants.FIRMWARE_VERSION_HEX_PREFIX,
                command.getFileVersion());
        if (!newFirmwareVersion.equals(getThing().getProperties().get(Thing.PROPERTY_FIRMWARE_VERSION))) {
            updateProperty(Thing.PROPERTY_FIRMWARE_VERSION, newFirmwareVersion);
        }

        // We always return null as we don't want to automatically start the OTA
        // Instead we should use the OH concept for firmware management which let's the
        // user know there's a
        // firmware waiting.
        return null;
    }

[cdjackson]

@pgaufillet are you actively testing OTA at the moment?

Mid mast year I made a load of changes to OTA, but as I've been travelling, I didn't complete this, and now I don't 100% remember where I got to. I think I got this working (better at least), but it may not account for your comments on this and the other issue #918.

I'm about to head back to the UK for a couple of weeks so might throw a device or two in my bag and try and close this out, but I'll push my WIP branch and possibly open a PR for visibility - if you're actively looking at OTA I'd appreciate your comments.

[pgaufillet]

Hello @cdjackson!

For the time being, I have only given it a try. I wanted to understand the current status of Zigbee OTA and the possible support for Legrand with Netatmo devices. The conclusion is that it is feasible. So yes: it is in my plans, but I wanted to exchange with you first as to avoid redeveloping things or doing something functionally weird. Your message is therefore a step forward :-)

I should be able to review your OTA branch in the coming weeks.

[cdjackson]

Hey @pgaufillet - I'm having a play with OTA at the moment and was wondering if you can clarify this issue...

It looks Legrand with Netatmo devices don't provide the firmware version during initialisation as expected.

What exactly is wrong?

The device really MUST request the image type in this request - I'm not sure how to work around this. The firmware version found in other clusters (ie BASIC) is typically different to that used in the OTA, and the OTA version is what is needed to link to the OTA files.

I've been testing OTA most of the weekend and it's working reasonable well (given I only have a problematic Philips battery remote to play with). I'm interested to better understand your issue...