fix: use dynamic port (#6)

cs50victor · web-flow · commit 0a0452c6d4b0 · 2026-02-20T11:31:42.000-08:00
* fix: use dynamic port

* fix: update hardcoded port 8080 to 38123 in tests, CI, and docs

* fix: replace hardcoded localhost:8080 with window.location.origin
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -130,7 +130,7 @@ jobs:
         shell: bash
         run: |
           for i in {1..30}; do
-            curl -s http://localhost:8080 > /dev/null && break
+            curl -s http://localhost:38123 > /dev/null && break
             sleep 1
           done
 
diff --git a/__tests__/desktop-stub-utils.test.js b/__tests__/desktop-stub-utils.test.js
@@ -260,18 +260,18 @@ describe('extractMediaFilename', () => {
 
 describe('buildMediaUrl', () => {
   test('constructs correct URL', () => {
-    const result = buildMediaUrl('http://localhost:8080', 'abc123', 'image.png');
-    expect(result).toBe('http://localhost:8080/api/media/abc123/image.png');
+    const result = buildMediaUrl('http://localhost:38123', 'abc123', 'image.png');
+    expect(result).toBe('http://localhost:38123/api/media/abc123/image.png');
   });
 
   test('encodes filename', () => {
-    const result = buildMediaUrl('http://localhost:8080', 'abc123', 'my image.png');
-    expect(result).toBe('http://localhost:8080/api/media/abc123/my%20image.png');
+    const result = buildMediaUrl('http://localhost:38123', 'abc123', 'my image.png');
+    expect(result).toBe('http://localhost:38123/api/media/abc123/my%20image.png');
   });
 
   test('handles special characters', () => {
-    const result = buildMediaUrl('http://localhost:8080', 'abc123', 'image (1).png');
-    expect(result).toBe('http://localhost:8080/api/media/abc123/image%20(1).png');
+    const result = buildMediaUrl('http://localhost:38123', 'abc123', 'image (1).png');
+    expect(result).toBe('http://localhost:38123/api/media/abc123/image%20(1).png');
   });
 });
 
@@ -283,17 +283,17 @@ describe('extractBlobUrl', () => {
   });
 
   test('extracts blob URL from string', () => {
-    const blobUrl = 'blob:http://localhost:8080/550e8400-e29b-41d4-a716-446655440000';
+    const blobUrl = 'blob:http://localhost:38123/550e8400-e29b-41d4-a716-446655440000';
     expect(extractBlobUrl(blobUrl)).toBe(blobUrl);
   });
 
   test('extracts blob URL from wrapped path', () => {
-    const wrapped = 'file:///path/to/blob:http://localhost:8080/550e8400-e29b-41d4-a716-446655440000/media/image.png';
-    expect(extractBlobUrl(wrapped)).toBe('blob:http://localhost:8080/550e8400-e29b-41d4-a716-446655440000');
+    const wrapped = 'file:///path/to/blob:http://localhost:38123/550e8400-e29b-41d4-a716-446655440000/media/image.png';
+    expect(extractBlobUrl(wrapped)).toBe('blob:http://localhost:38123/550e8400-e29b-41d4-a716-446655440000');
   });
 
   test('returns null for non-blob paths', () => {
-    expect(extractBlobUrl('http://localhost:8080/image.png')).toBe(null);
+    expect(extractBlobUrl('http://localhost:38123/image.png')).toBe(null);
     expect(extractBlobUrl('file:///path/to/image.png')).toBe(null);
     expect(extractBlobUrl('/media/image.png')).toBe(null);
   });
diff --git a/__tests__/logo-header.test.js b/__tests__/logo-header.test.js
@@ -3,7 +3,7 @@ import fs from 'fs';
 import path from 'path';
 import os from 'os';
 
-const SERVER_PORT = Number.parseInt(process.env.SERVER_PORT || '8080', 10);
+const SERVER_PORT = Number.parseInt(process.env.SERVER_PORT || '38123', 10);
 const SERVER_URL = process.env.SERVER_URL || `http://localhost:${SERVER_PORT}`;
 const LOAD_TIMEOUT = Number.parseInt(process.env.LOAD_TIMEOUT || '30000', 10);
 const LOGO_TIMEOUT = Number.parseInt(process.env.LOGO_TIMEOUT || '30000', 10);
diff --git a/__tests__/save.test.js b/__tests__/save.test.js
@@ -4,7 +4,7 @@ import fs from 'fs';
 import os from 'os';
 import crypto from 'crypto';
 
-const SERVER_URL = process.env.SERVER_URL || 'http://localhost:8080';
+const SERVER_URL = process.env.SERVER_URL || 'http://localhost:38123';
 const FIXTURES_DIR = path.resolve(import.meta.dir, '..', '.github/assets');
 const tempFiles = [];
 
diff --git a/__tests__/server-utils.test.js b/__tests__/server-utils.test.js
@@ -245,12 +245,12 @@ describe('generateX2TConfig', () => {
 
 describe('extractFilePathFromUrl', () => {
   test('extracts path from OnlyOffice URL format', () => {
-    const url = 'http://localhost:8080/api/onlyoffice/files/Users/test/file.xlsx';
+    const url = 'http://localhost:38123/api/onlyoffice/files/Users/test/file.xlsx';
     expect(extractFilePathFromUrl(url)).toBe('/Users/test/file.xlsx');
   });
 
   test('handles URL-encoded paths', () => {
-    const url = 'http://localhost:8080/api/onlyoffice/files/Users/test/my%20file.xlsx';
+    const url = 'http://localhost:38123/api/onlyoffice/files/Users/test/my%20file.xlsx';
     expect(extractFilePathFromUrl(url)).toBe('/Users/test/my file.xlsx');
   });
 
@@ -260,8 +260,8 @@ describe('extractFilePathFromUrl', () => {
   });
 
   test('returns null for non-matching URLs', () => {
-    expect(extractFilePathFromUrl('http://localhost:8080/other/path')).toBe(null);
-    expect(extractFilePathFromUrl('http://localhost:8080/api/convert')).toBe(null);
+    expect(extractFilePathFromUrl('http://localhost:38123/other/path')).toBe(null);
+    expect(extractFilePathFromUrl('http://localhost:38123/api/convert')).toBe(null);
   });
 
   test('returns null for non-URL input', () => {
diff --git a/build-min.txt b/build-min.txt
@@ -131,7 +131,7 @@ EDIT-BUILD-TEST WORKFLOW
 4. Start server and test:
    bun run server
 
-5. Open browser to http://localhost:8080/open?filepath=/path/to/file.xlsx
+5. Open browser to http://localhost:38123/open?filepath=/path/to/file.xlsx
 
 
 RUNTIME LOADING
diff --git a/download-converter.js b/download-converter.js
@@ -28,7 +28,7 @@ const os = require('os');
 // Project files modified from upstream (excluding test/CI/docs):
 //
 //   Server / Core:
-//     server.js                    - Express server (port 8080)
+//     server.js                    - Express server (dynamic port, default 38123)
 //     server-utils.js              - Server utility functions (added)
 //     download-converter.js        - Downloads ONLYOFFICE Desktop, extracts x2t (added)
 //     package.json                 - Dependencies and scripts
diff --git a/editors/desktop-stub.js b/editors/desktop-stub.js
@@ -66,7 +66,7 @@
                 // Synchronously upload image to server for persistence
                 var xhr = new XMLHttpRequest();
                 var serverFilename = 'dropped_' + Date.now() + '_' + i + '.' + ext;
-                xhr.open('POST', 'http://localhost:8080/api/media/' + fileHash + '?filename=' + encodeURIComponent(serverFilename), false);
+                xhr.open('POST', window.location.origin + '/api/media/' + fileHash + '?filename=' + encodeURIComponent(serverFilename), false);
                 xhr.setRequestHeader('Content-Type', 'application/octet-stream');
 
                 // Send File directly (File extends Blob, XHR handles it)
@@ -96,8 +96,7 @@
     console.log('Creating AscDesktopEditor stub for browser environment');
 
     // Server configuration
-    var SERVER_PORT = 8080;
-    var SERVER_BASE_URL = 'http://localhost:' + SERVER_PORT;
+    var SERVER_BASE_URL = window.location.origin;
 
     // Import utils from global (loaded before this script)
     var utils = window.DesktopStubUtils || {};
diff --git a/editors/offline-loader-proper.html b/editors/offline-loader-proper.html
@@ -132,8 +132,7 @@
             window._logTimings = logTimings;
 
             // Server configuration
-            const SERVER_PORT = 8080;
-            const SERVER_BASE_URL = 'http://localhost:' + SERVER_PORT;
+            const SERVER_BASE_URL = window.location.origin;
             window._ONLYOFFICE_SERVER_BASE_URL = SERVER_BASE_URL;
             window._ONLYOFFICE_DOC_BASE_URL = null;
             window._ONLYOFFICE_FILE_HASH = null;
diff --git a/server.js b/server.js
@@ -26,7 +26,7 @@ const FONT_DATA_DIR = isAbsolutePath(process.env.FONT_DATA_DIR)
 
 const app = express();
 app.use(compression());
-const PORT = 8080;
+const PORT = Number.parseInt(process.env.PORT || '38123', 10);
 const BASE_URL = `http://localhost:${PORT}`;
 
 // Enable CORS
diff --git a/test-console-batch.js b/test-console-batch.js
@@ -4,7 +4,7 @@ const path = require('path');
 const os = require('os');
 const http = require('http');
 
-const SERVER_PORT = Number.parseInt(process.env.SERVER_PORT || '8080', 10);
+const SERVER_PORT = Number.parseInt(process.env.SERVER_PORT || '38123', 10);
 const SERVER_URL = process.env.SERVER_URL || `http://localhost:${SERVER_PORT}`;
 const BATCH_SIZE = Number.parseInt(process.env.BATCH_SIZE || '5', 10);
 const LOAD_TIMEOUT = Number.parseInt(process.env.LOAD_TIMEOUT || '5000', 10);
diff --git a/test-desktop-stub-utils.js b/test-desktop-stub-utils.js
@@ -22,24 +22,24 @@ console.log('\n=== buildMediaUrl Tests ===\n');
 
 console.log('Valid inputs:');
 test('builds URL with all params',
-  utils.buildMediaUrl('http://localhost:8080', 'abc123', 'image.png') ===
-  'http://localhost:8080/api/media/abc123/image.png');
+  utils.buildMediaUrl('http://localhost:38123', 'abc123', 'image.png') ===
+  'http://localhost:38123/api/media/abc123/image.png');
 
 test('encodes filename with spaces',
-  utils.buildMediaUrl('http://localhost:8080', 'abc', 'my image.png').includes('my%20image.png'));
+  utils.buildMediaUrl('http://localhost:38123', 'abc', 'my image.png').includes('my%20image.png'));
 
 test('encodes unicode filename',
-  utils.buildMediaUrl('http://localhost:8080', 'abc', '画像.png').includes('%E7%94%BB%E5%83%8F.png'));
+  utils.buildMediaUrl('http://localhost:38123', 'abc', '画像.png').includes('%E7%94%BB%E5%83%8F.png'));
 
 console.log('\nMissing fileHash (BUG FIX - should return null):');
 test('returns null when fileHash is undefined',
-  utils.buildMediaUrl('http://localhost:8080', undefined, 'image.png') === null);
+  utils.buildMediaUrl('http://localhost:38123', undefined, 'image.png') === null);
 
 test('returns null when fileHash is null',
-  utils.buildMediaUrl('http://localhost:8080', null, 'image.png') === null);
+  utils.buildMediaUrl('http://localhost:38123', null, 'image.png') === null);
 
 test('returns null when fileHash is empty string',
-  utils.buildMediaUrl('http://localhost:8080', '', 'image.png') === null);
+  utils.buildMediaUrl('http://localhost:38123', '', 'image.png') === null);
 
 console.log('\n=== Results ===');
 console.log(`Passed: ${passed}`);
diff --git a/test-image.html b/test-image.html
@@ -3,13 +3,13 @@
 <head>
     <title>Image Load Test</title>
     <script>
-        const SERVER_PORT = 8080;
+        const SERVER_PORT = 38123;
         const SERVER_BASE_URL = 'http://localhost:' + SERVER_PORT;
     </script>
 </head>
 <body>
     <h1>Testing Image Load</h1>
-    <img id="test" src="http://localhost:8080/api/media/ba3e5be21444fe8a9558f25ed5ee35f4/image1.jpg"
+    <img id="test" src="http://localhost:38123/api/media/ba3e5be21444fe8a9558f25ed5ee35f4/image1.jpg"
          onload="console.log('Image loaded successfully!', this.naturalWidth, 'x', this.naturalHeight)"
          onerror="console.error('Image failed to load!')"
          style="border: 2px solid blue;">
diff --git a/test-url-scheme.js b/test-url-scheme.js
@@ -25,7 +25,7 @@ function test(description, condition) {
 console.log('\n=== URL Scheme Detection Tests ===\n');
 
 console.log('URLs WITH scheme (should match - no file:// prepended):');
-test('http://localhost:8080/api/doc-base/abc', schemeRegex.test('http://localhost:8080/api/doc-base/abc'));
+test('http://localhost:38123/api/doc-base/abc', schemeRegex.test('http://localhost:38123/api/doc-base/abc'));
 test('https://example.com/path', schemeRegex.test('https://example.com/path'));
 test('file:///path/to/document', schemeRegex.test('file:///path/to/document'));
 test('file://localhost/path', schemeRegex.test('file://localhost/path'));
