Skip to content

Commit c723e95

Browse files
committed
fix sidecarset e2e (#1724)
Signed-off-by: liheng.zms <[email protected]>
1 parent 991c0f4 commit c723e95

File tree

1 file changed

+15
-6
lines changed

1 file changed

+15
-6
lines changed

test/e2e/apps/sidecarset.go

+15-6
Original file line numberDiff line numberDiff line change
@@ -853,10 +853,12 @@ var _ = SIGDescribe("SidecarSet", func() {
853853
gomega.Expect(err).NotTo(gomega.HaveOccurred())
854854
for _, pod := range pods {
855855
origin := sets.String{}
856-
for _, sidecar := range sidecarSetIn.Spec.Containers {
857-
origin.Insert(sidecar.Name)
858-
}
859856
for _, sidecar := range sidecarSetIn.Spec.InitContainers {
857+
if sidecarcontrol.IsSidecarContainer(sidecar.Container) {
858+
origin.Insert(sidecar.Name)
859+
}
860+
}
861+
for _, sidecar := range sidecarSetIn.Spec.Containers {
860862
origin.Insert(sidecar.Name)
861863
}
862864
// SidecarSetHashAnnotation = "kruise.io/sidecarset-hash"
@@ -902,10 +904,12 @@ var _ = SIGDescribe("SidecarSet", func() {
902904
gomega.Expect(err).NotTo(gomega.HaveOccurred())
903905
for _, pod := range pods {
904906
origin := sets.String{}
905-
for _, sidecar := range sidecarSetIn.Spec.Containers {
906-
origin.Insert(sidecar.Name)
907-
}
908907
for _, sidecar := range sidecarSetIn.Spec.InitContainers {
908+
if sidecarcontrol.IsSidecarContainer(sidecar.Container) {
909+
origin.Insert(sidecar.Name)
910+
}
911+
}
912+
for _, sidecar := range sidecarSetIn.Spec.Containers {
909913
origin.Insert(sidecar.Name)
910914
}
911915
// SidecarSetHashAnnotation = "kruise.io/sidecarset-hash"
@@ -950,6 +954,11 @@ var _ = SIGDescribe("SidecarSet", func() {
950954
gomega.Expect(err).NotTo(gomega.HaveOccurred())
951955
for _, pod := range pods {
952956
origin := sets.String{}
957+
for _, sidecar := range sidecarSetIn.Spec.InitContainers {
958+
if sidecarcontrol.IsSidecarContainer(sidecar.Container) {
959+
origin.Insert(sidecar.Name)
960+
}
961+
}
953962
for _, sidecar := range sidecarSetIn.Spec.Containers {
954963
origin.Insert(sidecar.Name)
955964
}

0 commit comments

Comments
 (0)