move set logic into handle workload function

Signed-off-by: caijing <caijing.cai@alibaba-inc.com>

Author: ivan-cai

pkg/webhook/workload/mutating/workload_update_handler.go

@@ -107,10 +107,6 @@ func (h *WorkloadHandler) Handle(ctx context.Context, req admission.Request) adm
 				oldObj); err != nil {
 				return admission.Errored(http.StatusBadRequest, err)
 			}
-			// if the resources is updated by CD tools(like OCM,Karmada), the uid of new object is empty
-			if len(newObjClone.GetUID()) == 0 {
-				newObjClone.SetUID(oldObj.GetUID())
-			}
 			changed, err := h.handleCloneSet(newObjClone, oldObj)
 			if err != nil {
 				return admission.Errored(http.StatusBadRequest, err)
@@ -140,10 +136,6 @@ func (h *WorkloadHandler) Handle(ctx context.Context, req admission.Request) adm
 				oldObj); err != nil {
 				return admission.Errored(http.StatusBadRequest, err)
 			}
-			// if the resources is updated by CD tools(like OCM,Karmada), the uid of new object is empty
-			if len(newObjClone.GetUID()) == 0 {
-				newObjClone.SetUID(oldObj.GetUID())
-			}
 			changed, err := h.handleDaemonSet(newObjClone, oldObj)
 			if err != nil {
 				return admission.Errored(http.StatusBadRequest, err)
@@ -178,10 +170,6 @@ func (h *WorkloadHandler) Handle(ctx context.Context, req admission.Request) adm
 				oldObj); err != nil {
 				return admission.Errored(http.StatusBadRequest, err)
 			}
-			// if the resources is updated by CD tools(like OCM,Karmada), the uid of new object is empty
-			if len(newObjClone.GetUID()) == 0 {
-				newObjClone.SetUID(oldObj.GetUID())
-			}
 			changed, err := h.handleDeployment(newObjClone, oldObj)
 			if err != nil {
 				return admission.Errored(http.StatusBadRequest, err)
@@ -211,10 +199,6 @@ func (h *WorkloadHandler) Handle(ctx context.Context, req admission.Request) adm
 				oldObj); err != nil {
 				return admission.Errored(http.StatusBadRequest, err)
 			}
-			// if the resources is updated by CD tools(like OCM,Karmada), the uid of new object is empty
-			if len(newObjClone.GetUID()) == 0 {
-				newObjClone.SetUID(oldObj.GetUID())
-			}
 			changed, err := h.handleNativeDaemonSet(newObjClone, oldObj)
 			if err != nil {
 				return admission.Errored(http.StatusBadRequest, err)
@@ -238,6 +222,11 @@ func (h *WorkloadHandler) Handle(ctx context.Context, req admission.Request) adm
 }
 
 func (h *WorkloadHandler) handleDeployment(newObj, oldObj *apps.Deployment) (bool, error) {
+	// if the resources is updated by CD tools(like OCM,Karmada), the uid of new object is empty
+	if len(newObj.GetUID()) == 0 {
+		newObj.SetUID(oldObj.GetUID())
+	}
+
 	// make sure matched Rollout CR always exists
 	rollout, err := h.fetchMatchedRollout(newObj)
 	if err != nil {
@@ -360,6 +349,11 @@ func (h *WorkloadHandler) handleCloneSet(newObj, oldObj *kruiseappsv1alpha1.Clon
 		return false, nil
 	}
 
+	// if the resources is updated by CD tools(like OCM,Karmada), the uid of new object is empty
+	if len(newObj.GetUID()) == 0 {
+		newObj.SetUID(oldObj.GetUID())
+	}
+
 	rollout, err := h.fetchMatchedRollout(newObj)
 	if err != nil {
 		return false, err
@@ -394,6 +388,11 @@ func (h *WorkloadHandler) handleDaemonSet(newObj, oldObj *kruiseappsv1alpha1.Dae
 		return false, nil
 	}
 
+	// if the resources is updated by CD tools(like OCM,Karmada), the uid of new object is empty
+	if len(newObj.GetUID()) == 0 {
+		newObj.SetUID(oldObj.GetUID())
+	}
+
 	rollout, err := h.fetchMatchedRollout(newObj)
 	if err != nil {
 		return false, err
@@ -516,6 +515,11 @@ func (h *WorkloadHandler) handleNativeDaemonSet(newObj, oldObj *apps.DaemonSet)
 		return false, nil
 	}
 
+	// if the resources is updated by CD tools(like OCM,Karmada), the uid of new object is empty
+	if len(newObj.GetUID()) == 0 {
+		newObj.SetUID(oldObj.GetUID())
+	}
+
 	rollout, err := h.fetchMatchedRollout(newObj)
 	if err != nil {
 		return false, err