Skip to content

Commit 87f7e65

Browse files
author
Parship Chowdhury
authored
Fix workload webhook filtering: patch label bug and add Kruise StatefulSet support (#299)
* Fix workload type label patching bug and add Kruise StatefulSet support Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com> * added objectSelector to filter workloads by rollout label Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com> * reverted the changes in manifest Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com> --------- Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
1 parent b2806f5 commit 87f7e65

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/controller/rollout/rollout_status.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,10 +298,12 @@ func (r *RolloutReconciler) patchWorkloadRolloutWebhookLabel(rollout *v1beta1.Ro
298298
workloadType = util.DeploymentType
299299
case util.ControllerKindSts.Kind:
300300
workloadType = util.StatefulSetType
301+
case util.ControllerKruiseKindSts.Kind, util.ControllerKruiseOldKindSts.Kind:
302+
workloadType = util.StatefulSetType
301303
case util.ControllerKruiseKindDS.Kind:
302304
workloadType = util.DaemonSetType
303305
}
304-
if workload.Annotations[util.WorkloadTypeLabel] == "" && workloadType != "" {
306+
if workload.Labels[util.WorkloadTypeLabel] == "" && workloadType != "" {
305307
workloadGVK := schema.FromAPIVersionAndKind(workload.APIVersion, workload.Kind)
306308
obj := util.GetEmptyWorkloadObject(workloadGVK)
307309
obj.SetNamespace(workload.Namespace)

0 commit comments

Comments
 (0)