Skip to content

Commit 8df6cde

Browse files
committed
hotfix: fixes a bug that caused the decline template to show for accept.
1 parent 891066d commit 8df6cde

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/review/views.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
__maintainer__ = "Birkbeck Centre for Technology and Publishing"
55

66

7-
from uuid import uuid4
87
from collections import Counter
98
from datetime import timedelta
109

@@ -749,7 +748,7 @@ def remove_file(request, article_id, round_id, file_id):
749748
messages.add_message(
750749
request,
751750
messages.INFO,
752-
"Cannot remove a file from a closed review round.".format(file.label),
751+
"Cannot remove a file from a closed review round.",
753752
)
754753
return redirect(reverse("review_in_review", kwargs={"article_id": article_id}))
755754

@@ -1766,7 +1765,7 @@ def review_decision(request, article_id, decision):
17661765
request, article, decision, author_review_url
17671766
)
17681767
setting_name = "review_decision_{0}".format(decision)
1769-
if article.stage == submission_models.STAGE_UNASSIGNED:
1768+
if article.stage == submission_models.STAGE_UNASSIGNED and decision == 'decline':
17701769
setting_name = "review_decision_desk_reject"
17711770

17721771
form = core_forms.SettingEmailForm(

0 commit comments

Comments
 (0)