Skip to content

Commit a4d4666

Browse files
StephDriverajrbyers
authored andcommitted
a11y: #4886 clean news pagniation to include ellipsis
1 parent f0d77af commit a4d4666

File tree

2 files changed

+29
-17
lines changed

2 files changed

+29
-17
lines changed

src/themes/clean/templates/core/news/index.html

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{% extends "core/base.html" %}
22
{% load truncate %}
33
{% load dates %}
4+
{% load pages %}
45

56
{% block title %}{{ journal_settings.news.news_title }}{% endblock title %}
67

@@ -35,21 +36,25 @@ <h2> {% trans 'This journal currently has no {{ journal_settings.news.news_title
3536
</li>
3637
{% endif %}
3738

38-
{% for page in news_items.paginator.page_range %}
39-
{% if news_items.number == page %}
39+
{% for page in news_items|slice_pages_with_first_last_ellipsis:2 %}
40+
{% if page == '...' %}
4041
<li class="list-inline-item">
41-
<a href="?page={{ page }}"
42+
<span class="btn btn-outline-secondary" disabled>...</span>
43+
</li>
44+
{% elif news_items.number == page.number %}
45+
<li class="list-inline-item">
46+
<a href="?page={{ page.number }}"
4247
class="btn btn-primary"
4348
>
44-
<span class="sr-only">{% trans 'current page' %}</span>{{ page }}
49+
<span class="sr-only">{% trans 'current page' %}</span>{{ page.number }}
4550
</a>
4651
</li>
4752
{% else %}
4853
<li class="list-inline-item">
49-
<a href="?page={{ page }}"
54+
<a href="?page={{ page.number }}"
5055
class="btn btn-outline-primary"
5156
>
52-
<span class="sr-only">{% trans 'page' %}</span>{{ page }}
57+
<span class="sr-only">{% trans 'page' %}</span>{{ page.number }}
5358
</a>
5459
</li>
5560
{% endif %}

src/themes/clean/templates/press/core/news/index.html

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{% extends "core/base.html" %}
22
{% load truncate %}
33
{% load dates %}
4+
{% load pages %}
45

56
{% block title %}News{% endblock title %}
67

@@ -34,20 +35,26 @@ <h2>{% trans 'This journal currently has no news items to display' %}.</h2>
3435
</a>
3536
</li>
3637
{% endif %}
37-
{{ news_items.page.page_range }}
38-
{% for page in news_items.paginator.page_range %}
39-
<li class="list-inline-item">
40-
{% if news_items.number == page %}
41-
<a href="?page={{ page }}"
38+
{% for page in news_items|slice_pages_with_first_last_ellipsis:2 %}
39+
{% if page == '...' %}
40+
<li class="list-inline-item">
41+
<span class="btn btn-outline-secondary" disabled>...</span>
42+
</li>
43+
{% elif news_items.number == page.number %}
44+
<li class="list-inline-item">
45+
<a href="?page={{ page.number }}"
4246
class="btn btn-primary">
43-
<span class="sr-only">{% trans 'current page' %}</span>{{ page }}
47+
<span class="sr-only">{% trans 'current page' %}</span>{{ page.number }}
4448
</a>
45-
{% else %}
46-
<a href="?page={{ page }}"
47-
class="btn btn-outline-primary">{{ page }}
49+
</li>
50+
{% else %}
51+
<li class="list-inline-item">
52+
<a href="?page={{ page.number }}"
53+
class="btn btn-outline-primary">
54+
<span class="sr-only">{% trans 'page' %}</span>{{ page.number }}
4855
</a>
49-
{% endif %}
50-
</li>
56+
</li>
57+
{% endif %}
5158
{% endfor %}
5259
{% if news_items.has_next %}
5360
<li class="list-inline-item">

0 commit comments

Comments
 (0)