Add raw-track-access mode support for ECKD disks#867
Add raw-track-access mode support for ECKD disks#867asmit27rai wants to merge 2 commits intoopenmainframeproject:masterfrom
Conversation
Signed-off-by: asmit27rai <raiasmit10@gmail.com>
asmit27rai
force-pushed
the
feature/raw-track-eckd
branch
from
32b498b to
4871af7
Compare
|
@Bischoff Pls review this PR |
Bischoff
left a comment
Bischoff
left a comment
There was a problem hiding this comment.
Thanks for the great PR, but this looks to me incomplete:
- Aren't we missing something in
zvmsdk/api.py? Here:
def image_import(self, image_name, url, image_meta, remote_host=None):
"""Import image to zvmsdk image repository
- Shouldn't we adapt unit tests? Like in
zvmsdk/tests/unit/test_imageops.py - Please udate documentation so the new parameter appears in https://cloudlib4zvm.readthedocs.io/en/latest/restapi.html#create-image
- and every other place I might have missed...
|
@asmit27rai I can see you are candidate for the 2025 Linux Foundation mentorship. Be warned that candidates are selected first on their resumes, then on an online interview. Open Source contributions are not taken into account in this selection process. Don't contribute in the hope it will make you selected. Don't misunderstand me: your contributions are really impressive, and they are much appreciated! Thank you! But if you do them, just do them for the fun, or for the sake of the project, or out of curiosity. There is no reward implied. As an unrelated side note, I doubt you have been able to test your code. Before merging it, we would need to test it in a real mainframe testbed. |
| [[ $mode ]] || mode='rr' | ||
|
|
||
| # Ensure rawTrackAccess 1 is passed for raw mode | ||
| vmcp "link $userID $vdev as $alias $mode" 2>&1 |
There was a problem hiding this comment.
Can you please explain this line?
I don't see how rawTrackAccess is used in this command.
2 participants
Summary
Adds support for raw-track-access mode on ECKD disks, allowing Feilong to handle:
Related Issues
Fixes: #714