Skip to content

Commit 2ab8cd0

Browse files
authored
fix: otel attr for http client address (#4535)
1 parent 5b4ce3d commit 2ab8cd0

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

pkg/server/attributes.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,14 @@ func GetRequestAttributes(r *http.Request) map[string]string {
2525
string(semconv.UserAgentOriginalKey): r.UserAgent(),
2626
}
2727

28-
if clientIP := middleware.GetClientIPAddr(ctx); clientIP.IsValid() {
29-
attrs[string(semconv.NetworkPeerAddressKey)] = clientIP.String()
30-
} else if ip, port, err := net.SplitHostPort(r.RemoteAddr); err == nil {
31-
attrs[string(semconv.NetworkPeerAddressKey)] = ip
32-
attrs[string(semconv.NetworkPeerPortKey)] = port
28+
peerAddr, peerPort, err := net.SplitHostPort(r.RemoteAddr)
29+
if err == nil {
30+
attrs[string(semconv.NetworkPeerAddressKey)] = peerAddr
31+
attrs[string(semconv.NetworkPeerPortKey)] = peerPort
32+
}
33+
34+
if clientAddr := middleware.GetClientIPAddr(ctx); clientAddr.IsValid() {
35+
attrs[string(semconv.ClientAddressKey)] = clientAddr.String()
3336
}
3437

3538
if reqID := middleware.GetReqID(ctx); reqID != "" {

0 commit comments

Comments
 (0)