Revert "refactor(isodate): make it so an hour divides a day"

This reverts commit 6fe23ee.

Author: GAlexIHU

pkg/isodate/date.go

@@ -137,11 +137,6 @@ func (p Period) DivisibleBy(smaller Period) (bool, error) {
 		return true, nil // Years/months always contain days
 	}
 
-	// Days are conceptually divisible by hours/minutes/seconds
-	if p.isDayLike() && smaller.isTimeLike() {
-		return true, nil // Days always contain hours/minutes/seconds
-	}
-
 	var err error
 	per := smaller
 	for i := 1; i < MAX_SAFE_ITERATION_COUNT; i++ {
@@ -180,19 +175,6 @@ func (p Period) isDay() bool {
 		p.Period.Hours() == 0 && p.Period.Minutes() == 0 && p.Period.Seconds() == 0
 }
 
-// isDayLike returns true if the period contains only days (potentially more than 1)
-func (p Period) isDayLike() bool {
-	return p.Period.Days() > 0 &&
-		p.Period.Years() == 0 && p.Period.Months() == 0 && p.Period.Weeks() == 0 &&
-		p.Period.Hours() == 0 && p.Period.Minutes() == 0 && p.Period.Seconds() == 0
-}
-
-// isTimeLike returns true if the period contains only hours, minutes, and/or seconds
-func (p Period) isTimeLike() bool {
-	return (p.Period.Hours() != 0 || p.Period.Minutes() != 0 || p.Period.Seconds() != 0) &&
-		p.Period.Years() == 0 && p.Period.Months() == 0 && p.Period.Weeks() == 0 && p.Period.Days() == 0
-}
-
 func Between(start time.Time, end time.Time) Period {
 	per := period.Between(start, end)
 	return Period{per}

pkg/isodate/date_test.go

@@ -179,45 +179,45 @@ func TestDivisibleBy(t *testing.T) {
 			hasError: false,
 		},
 		{
-			name:     "1 day divisible by 1 hour",
+			name:     "1 day not divisible by 1 hour (different units)",
 			larger:   "P1D",
 			smaller:  "PT1H",
-			expected: true,
+			expected: false,
 			hasError: false,
 		},
 		{
-			name:     "1 day divisible by 2 hours",
+			name:     "1 day not divisible by 2 hours (different units)",
 			larger:   "P1D",
 			smaller:  "PT2H",
-			expected: true,
+			expected: false,
 			hasError: false,
 		},
 		{
-			name:     "1 day divisible by 4 hours",
+			name:     "1 day not divisible by 4 hours (different units)",
 			larger:   "P1D",
 			smaller:  "PT4H",
-			expected: true,
+			expected: false,
 			hasError: false,
 		},
 		{
-			name:     "1 day divisible by 6 hours",
+			name:     "1 day not divisible by 6 hours (different units)",
 			larger:   "P1D",
 			smaller:  "PT6H",
-			expected: true,
+			expected: false,
 			hasError: false,
 		},
 		{
-			name:     "1 day divisible by 8 hours",
+			name:     "1 day not divisible by 8 hours (different units)",
 			larger:   "P1D",
 			smaller:  "PT8H",
-			expected: true,
+			expected: false,
 			hasError: false,
 		},
 		{
-			name:     "1 day divisible by 12 hours",
+			name:     "1 day not divisible by 12 hours (different units)",
 			larger:   "P1D",
 			smaller:  "PT12H",
-			expected: true,
+			expected: false,
 			hasError: false,
 		},
 		{