fix: tests

tothandras · tothandras · commit bde3f73e743f · 2025-05-28T14:14:01.000+02:00
diff --git a/openmeter/productcatalog/plan.go b/openmeter/productcatalog/plan.go
@@ -119,10 +119,11 @@ func (p Plan) ValidForCreatingSubscriptions() error {
 				))
 			}
 		}
-	}
 
-	if err := p.ValidateWith(PlanHasAlignedBillingCadences(p)); err != nil {
-		errs = append(errs, err)
+		// TODO: move this out as soon as we remove alignment setting
+		if err := p.ValidateWith(PlanHasAlignedBillingCadences(p)); err != nil {
+			errs = append(errs, err)
+		}
 	}
 
 	return errors.Join(errs...)

Original file line number	Diff line number	Diff line change
`@@ -119,10 +119,11 @@ func (p Plan) ValidForCreatingSubscriptions() error {`
`119`	`119`	`))`
`120`	`120`	`}`
`121`	`121`	`}`
`122`		`- }`
`123`	`122`
`124`		`- if err := p.ValidateWith(PlanHasAlignedBillingCadences(p)); err != nil {`
`125`		`- errs = append(errs, err)`
	`123`	`+ // TODO: move this out as soon as we remove alignment setting`
	`124`	`+ if err := p.ValidateWith(PlanHasAlignedBillingCadences(p)); err != nil {`
	`125`	`+ errs = append(errs, err)`
	`126`	`+ }`
`126`	`127`	`}`
`127`	`128`
`128`	`129`	`return errors.Join(errs...)`