feat(billing): rename WithDeprecatedTaxCodeEnforced

Author: borbelyr-kong

openmeter/billing/profile.go

@@ -110,7 +110,7 @@ func (c *InvoicingConfig) Validate() error {
 	return nil
 }
 
-// EnforceTaxCodeDeprecation returns a ValidationError when the receiver adds or changes a
+// WithDeprecatedTaxCodeEnforced returns a ValidationError when the receiver adds or changes a
 // deprecated tax-code field (stripe.code or taxCodeId) relative to stored. stored is the
 // zero InvoicingConfig on create. Removal is permitted; behavior is never restricted.
 // Call it on the raw API->domain mapped incoming config, BEFORE tax-code resolution.
@@ -120,7 +120,7 @@ func (c *InvoicingConfig) Validate() error {
 // too), otherwise tax-code resolution would backfill stripe.code from the referenced tax code
 // entity. The reverse (taxCodeId omitted, stripe.code echoed unchanged) is left untouched,
 // because legacy clients that predate taxCodeId send exactly that shape on no-op updates.
-func (c InvoicingConfig) EnforceTaxCodeDeprecation(stored InvoicingConfig) (InvoicingConfig, error) {
+func (c InvoicingConfig) WithDeprecatedTaxCodeEnforced(stored InvoicingConfig) (InvoicingConfig, error) {
 	if c.DefaultTaxConfig == nil {
 		return c, nil
 	}

openmeter/billing/profile_test.go

@@ -10,7 +10,7 @@ import (
 	"github.com/openmeterio/openmeter/openmeter/productcatalog"
 )
 
-func TestInvoicingConfigEnforceTaxCodeDeprecation(t *testing.T) {
+func TestInvoicingConfigWithDeprecatedTaxCodeEnforced(t *testing.T) {
 	taxConfig := func(behavior *productcatalog.TaxBehavior, stripeCode string, taxCodeID *string) *productcatalog.TaxConfig {
 		tc := &productcatalog.TaxConfig{
 			Behavior:  behavior,
@@ -208,7 +208,7 @@ func TestInvoicingConfigEnforceTaxCodeDeprecation(t *testing.T) {
 			}
 
 			incoming := InvoicingConfig{DefaultTaxConfig: tt.incoming}
-			result, err := incoming.EnforceTaxCodeDeprecation(InvoicingConfig{DefaultTaxConfig: tt.stored})
+			result, err := incoming.WithDeprecatedTaxCodeEnforced(InvoicingConfig{DefaultTaxConfig: tt.stored})
 			if !tt.wantErr {
 				require.NoError(t, err)
 

openmeter/billing/service/profile.go

@@ -82,7 +82,7 @@ func (s *Service) CreateProfile(ctx context.Context, input billing.CreateProfile
 		}
 
 		// billing.InvoicingConfig{} is the zero-value stored state for creates (no prior tax-code to compare against).
-		normalizedInvoicing, err := input.WorkflowConfig.Invoicing.EnforceTaxCodeDeprecation(billing.InvoicingConfig{})
+		normalizedInvoicing, err := input.WorkflowConfig.Invoicing.WithDeprecatedTaxCodeEnforced(billing.InvoicingConfig{})
 		if err != nil {
 			return nil, err
 		}
@@ -288,7 +288,7 @@ func (s *Service) UpdateProfile(ctx context.Context, input billing.UpdateProfile
 
 		targetState := billing.BaseProfile(input)
 
-		normalizedInvoicing, err := targetState.WorkflowConfig.Invoicing.EnforceTaxCodeDeprecation(profile.WorkflowConfig.Invoicing)
+		normalizedInvoicing, err := targetState.WorkflowConfig.Invoicing.WithDeprecatedTaxCodeEnforced(profile.WorkflowConfig.Invoicing)
 		if err != nil {
 			return nil, err
 		}