-
Notifications
You must be signed in to change notification settings - Fork 5
Expand file tree
/
Copy pathSafeTrackNameTest.cpp
More file actions
147 lines (123 loc) · 5.07 KB
/
Copy pathSafeTrackNameTest.cpp
File metadata and controls
147 lines (123 loc) · 5.07 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
/*
* Copyright (c) OpenMOQ contributors.
* This source code is licensed under the Apache 2.0 license found in the
* LICENSE file in the root directory of this source tree.
*/
#include "SafeTrackName.h"
#include <gtest/gtest.h>
namespace openmoq::moqx {
TEST(SafeTrackNameTest, PassesThroughUnreservedBytes) {
EXPECT_EQ(safeName("abcXYZ019_"), "abcXYZ019_");
}
TEST(SafeTrackNameTest, EncodesEverythingElseAsLowerHex) {
EXPECT_EQ(safeName("a.b"), "a.2eb");
EXPECT_EQ(safeName("a/b"), "a.2fb");
EXPECT_EQ(safeName(" "), ".20");
EXPECT_EQ(safeName("\n"), ".0a");
EXPECT_EQ(safeName("\xff"), ".ff");
EXPECT_EQ(safeName(std::string_view("\0", 1)), ".00");
}
// The separators are only unambiguous because '-' does not pass through.
TEST(SafeTrackNameTest, EncodesHyphen) {
EXPECT_EQ(safeName("a-b"), "a.2db");
}
TEST(SafeTrackNameTest, JoinsNamespaceTuplesWithHyphen) {
moxygen::TrackNamespace ns{{"conf", "room1", "layer0"}};
EXPECT_EQ(safeName(ns), "conf-room1-layer0");
}
TEST(SafeTrackNameTest, EmptyNamespaceAndTuples) {
EXPECT_EQ(safeName(moxygen::TrackNamespace{}), "");
moxygen::TrackNamespace ns{{"", ""}};
EXPECT_EQ(safeName(ns), "-");
}
TEST(SafeTrackNameTest, SeparatesTrackNameWithDoubleHyphen) {
moxygen::FullTrackName ftn{moxygen::TrackNamespace{{"conf", "room1"}}, "video"};
EXPECT_EQ(safeName(ftn), "conf-room1--video");
}
TEST(SafeTrackNameTest, RendersBinaryNamesReadablyWhereItCan) {
moxygen::FullTrackName ftn{
moxygen::TrackNamespace{{"conf.example.com", std::string("bin\xff\x01", 5)}},
"video-1"
};
EXPECT_EQ(safeName(ftn), "conf.2eexample.2ecom-bin.ff.01--video.2d1");
}
// Names that differ only outside the pass-through set must not collapse onto
// one rendering; metric labels key on the result.
TEST(SafeTrackNameTest, DistinctNamesStayDistinct) {
EXPECT_NE(safeName("\xc3\xa9"), safeName("\xc3\xa8"));
EXPECT_NE(safeName("a-b"), safeName("a_b"));
moxygen::TrackNamespace twoTuples{{"a", "b"}};
moxygen::TrackNamespace oneTuple{{"a-b"}};
EXPECT_NE(safeName(twoTuples), safeName(oneTuple));
}
TEST(SafeTrackNameTest, ParsesBytesBackToOriginal) {
EXPECT_EQ(parseSafeBytes("abcXYZ019_"), "abcXYZ019_");
EXPECT_EQ(parseSafeBytes("a.2eb"), "a.b");
EXPECT_EQ(parseSafeBytes(".ff"), "\xff");
EXPECT_EQ(parseSafeBytes(""), "");
EXPECT_EQ(parseSafeBytes(std::string_view(".00")), std::string_view("\0", 1));
}
TEST(SafeTrackNameTest, ParsesEitherHexCase) {
EXPECT_EQ(parseSafeBytes(".FF"), "\xff");
EXPECT_EQ(parseSafeBytes(".aB"), "\xab");
}
TEST(SafeTrackNameTest, RejectsMalformedBytes) {
EXPECT_FALSE(parseSafeBytes("a."));
EXPECT_FALSE(parseSafeBytes("a.2"));
EXPECT_FALSE(parseSafeBytes(".zz"));
EXPECT_FALSE(parseSafeBytes("a b"));
// Separators are not part of a component's alphabet.
EXPECT_FALSE(parseSafeBytes("a-b"));
// Neither a sign nor leading space may stand in for a hex digit.
EXPECT_FALSE(parseSafeBytes(".-1"));
EXPECT_FALSE(parseSafeBytes(". 1"));
EXPECT_FALSE(parseSafeBytes(".0x"));
}
TEST(SafeTrackNameTest, ParsesNamespaceTuples) {
auto ns = parseSafeNamespace("conf-room1-layer0");
ASSERT_TRUE(ns);
EXPECT_EQ(ns->trackNamespace, std::vector<std::string>({"conf", "room1", "layer0"}));
auto empty = parseSafeNamespace("");
ASSERT_TRUE(empty);
EXPECT_TRUE(empty->trackNamespace.empty());
auto emptyTuples = parseSafeNamespace("-");
ASSERT_TRUE(emptyTuples);
EXPECT_EQ(emptyTuples->trackNamespace, std::vector<std::string>({"", ""}));
}
TEST(SafeTrackNameTest, ParsesFullTrackName) {
auto ftn = parseSafeFullTrackName("conf-room1--video");
ASSERT_TRUE(ftn);
EXPECT_EQ(ftn->trackNamespace.trackNamespace, std::vector<std::string>({"conf", "room1"}));
EXPECT_EQ(ftn->trackName, "video");
}
TEST(SafeTrackNameTest, RejectsFullTrackNameWithoutSeparator) {
EXPECT_FALSE(parseSafeFullTrackName("conf-room1"));
EXPECT_FALSE(parseSafeFullTrackName(""));
}
// The last "--" wins, so a namespace ending in an empty tuple still splits
// where the encoder put the separator.
TEST(SafeTrackNameTest, ParsesEmptyTuplesAroundSeparator) {
auto trailing = parseSafeFullTrackName("a---v");
ASSERT_TRUE(trailing);
EXPECT_EQ(trailing->trackNamespace.trackNamespace, std::vector<std::string>({"a", ""}));
EXPECT_EQ(trailing->trackName, "v");
auto emptyTrack = parseSafeFullTrackName("a--");
ASSERT_TRUE(emptyTrack);
EXPECT_EQ(emptyTrack->trackNamespace.trackNamespace, std::vector<std::string>({"a"}));
EXPECT_EQ(emptyTrack->trackName, "");
}
TEST(SafeTrackNameTest, RoundTripsAwkwardNames) {
const std::vector<moxygen::FullTrackName> names{
{moxygen::TrackNamespace{{"conf.example.com", "room 1"}}, "video-1"},
{moxygen::TrackNamespace{{"a", ""}}, ""},
{moxygen::TrackNamespace{{std::string("\x00\xff-", 3)}}, std::string("\n\t", 2)},
{moxygen::TrackNamespace{}, "solo"},
};
for (const auto& ftn : names) {
auto parsed = parseSafeFullTrackName(safeName(ftn));
ASSERT_TRUE(parsed) << safeName(ftn);
EXPECT_EQ(parsed->trackNamespace.trackNamespace, ftn.trackNamespace.trackNamespace);
EXPECT_EQ(parsed->trackName, ftn.trackName);
}
}
} // namespace openmoq::moqx