Commit 850e8f2
moq_decode: request_id left response messages in draft-17, not 18
Per the draft-17 spec text, Request ID was already removed from
PUBLISH_DONE, SUBSCRIBE_OK, REQUEST_OK, REQUEST_ERROR and FETCH_OK in
draft-17 (implicit from the bidi request stream context). The tool's
gates said draft < 18, copied from MoQFramer -- but moxygen skips
draft 17 entirely (kSupportedVersions = 14/15/16/18), so its < 18
gates are only ever exercised as <= 16 and happen to work. For a
spec decoder with an explicit --version flag, < 17 is the correct
boundary.
Fixes:
- PUBLISH_DONE and FETCH_OK read request_id unconditionally; gate them.
- SUBSCRIBE_OK / REQUEST_OK / REQUEST_ERROR gates corrected 18 -> 17.
Reported by a user decoding draft-17 PUBLISH_DONE frames.1 parent 0ee1d9d commit 850e8f2
1 file changed
Lines changed: 14 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
517 | 517 | | |
518 | 518 | | |
519 | 519 | | |
520 | | - | |
521 | | - | |
| 520 | + | |
| 521 | + | |
522 | 522 | | |
523 | 523 | | |
524 | 524 | | |
| |||
545 | 545 | | |
546 | 546 | | |
547 | 547 | | |
548 | | - | |
| 548 | + | |
549 | 549 | | |
550 | | - | |
| 550 | + | |
551 | 551 | | |
552 | 552 | | |
553 | 553 | | |
| |||
569 | 569 | | |
570 | 570 | | |
571 | 571 | | |
572 | | - | |
573 | | - | |
| 572 | + | |
| 573 | + | |
574 | 574 | | |
575 | 575 | | |
576 | 576 | | |
| |||
610 | 610 | | |
611 | 611 | | |
612 | 612 | | |
613 | | - | |
614 | | - | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
615 | 617 | | |
616 | 618 | | |
617 | 619 | | |
| |||
777 | 779 | | |
778 | 780 | | |
779 | 781 | | |
780 | | - | |
781 | | - | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
782 | 786 | | |
783 | 787 | | |
784 | 788 | | |
| |||
0 commit comments