Fix asan dual-linkage: remove static lib preference from san preset

The san preset had CMAKE_FIND_LIBRARY_SUFFIXES=".a" which caused
find_dependency(Glog) to find libglog.a, while the tarball's
folly-targets.cmake hardcodes libglog.so. Both copies loaded under
ASAN, crashing on glog's logtostderr flag double-registration.

Removing the static preference lets the san build link consistently
against .so files for system deps. Also reverts the temporary
continue-on-error for asan.

Author: gmarzot

.github/workflows/ci-pr.yml

@@ -95,10 +95,8 @@ jobs:
             preset: san
             build_dir: build-san
             runner: ubuntu-22.04
-            allow_failure: true
     name: ${{ matrix.name }}
     runs-on: ${{ matrix.runner }}
-    continue-on-error: ${{ matrix.allow_failure || false }}
     steps:
       - name: Generate app token
         id: app-token

CMakePresets.json

@@ -26,7 +26,6 @@
       "cacheVariables": {
         "CMAKE_BUILD_TYPE": "Debug",
         "ORLY_ENABLE_SANITIZERS": "ON",
-        "CMAKE_FIND_LIBRARY_SUFFIXES": ".a",
         "CMAKE_MODULE_PATH": "${sourceDir}/cmake",
         "CMAKE_POLICY_VERSION_MINIMUM": "3.5"
       }