Skip to content

Commit fb07f3a

Browse files
authored
Merge pull request #19 from mondain/copilot/fix-failing-github-actions-job
Fix macOS legacy build break from incomplete `DrmSystemConfig` in `cmsf_packager` defaults
2 parents 314036b + 06ccf88 commit fb07f3a

2 files changed

Lines changed: 26 additions & 4 deletions

File tree

include/openmoq/publisher/cmsf_packager.h

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,13 @@ PublishPlan build_publish_plan(const SegmentedMp4& segmented_mp4,
6464
DraftVersion version,
6565
bool include_sap = false,
6666
bool include_msf_timeline = false,
67-
bool vod = false,
68-
const std::vector<DrmSystemConfig>& drm_systems = {});
67+
bool vod = false);
68+
PublishPlan build_publish_plan(const SegmentedMp4& segmented_mp4,
69+
DraftVersion version,
70+
bool include_sap,
71+
bool include_msf_timeline,
72+
bool vod,
73+
const std::vector<DrmSystemConfig>& drm_systems);
6974
std::string render_publish_plan(const PublishPlan& plan);
7075
PublishPlan materialize_publish_plan(const PublishPlan& plan, std::span<const std::uint8_t> bytes);
7176
void emit_plan_objects(const PublishPlan& plan,
@@ -84,8 +89,11 @@ struct LiveCatalog {
8489
};
8590
LiveCatalog build_live_catalog(const std::vector<TrackDescription>& tracks,
8691
std::span<const std::uint8_t> init_segment,
87-
bool is_live = true,
88-
const std::vector<DrmSystemConfig>& drm_systems = {});
92+
bool is_live = true);
93+
LiveCatalog build_live_catalog(const std::vector<TrackDescription>& tracks,
94+
std::span<const std::uint8_t> init_segment,
95+
bool is_live,
96+
const std::vector<DrmSystemConfig>& drm_systems);
8997

9098
// Base64-encoded, track-specific CMAF init segment (ftyp + single-track moov)
9199
// for the track at track_index within init_segment. This is exactly the value

src/cmsf_packager.cpp

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,14 @@ std::vector<CencSystem> collect_pssh_systems(std::span<const std::uint8_t> init_
420420
return parse_pssh_boxes(init_bytes, pssh_boxes);
421421
}
422422

423+
PublishPlan build_publish_plan(const SegmentedMp4& segmented_mp4,
424+
DraftVersion version,
425+
bool include_sap,
426+
bool include_msf_timeline,
427+
bool vod) {
428+
return build_publish_plan(segmented_mp4, version, include_sap, include_msf_timeline, vod, {});
429+
}
430+
423431
PublishPlan build_publish_plan(const SegmentedMp4& segmented_mp4,
424432
DraftVersion version,
425433
bool include_sap,
@@ -709,6 +717,12 @@ void emit_plan_objects(const PublishPlan& plan,
709717
manifest << render_publish_plan(plan);
710718
}
711719

720+
LiveCatalog build_live_catalog(const std::vector<TrackDescription>& tracks,
721+
std::span<const std::uint8_t> init_segment,
722+
bool is_live) {
723+
return build_live_catalog(tracks, init_segment, is_live, {});
724+
}
725+
712726
LiveCatalog build_live_catalog(const std::vector<TrackDescription>& tracks,
713727
std::span<const std::uint8_t> init_segment,
714728
bool is_live,

0 commit comments

Comments
 (0)