Skip to content

(feat) O3-2971: Show a confirmation modal when the user submits an empty form #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

(feat) O3-2971: Show a confirmation modal when the user submits an empty form #464

wants to merge 11 commits into from

Conversation

UNCANNY69
Copy link

@UNCANNY69 UNCANNY69 commented Feb 9, 2025 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR adds a feature which triggers a conformation modal when User submits an empty form.

Screenshots

OpenMRS.-.Google.Chrome.2025-02-11.23-09-36.mp4

Related Issue

Other

@UNCANNY69 UNCANNY69 changed the title Adding conformation modal for empty form (feat)O3-2971: Adding conformation modal for an empty form. Feb 9, 2025
@UNCANNY69
Copy link
Author

I made many changes to the form-factory-provider , I would like it to be reviewed in case it can be designed better @NethmiRodrigo @samuelmale @denniskigen

samuelmale
samuelmale reviewed Feb 10, 2025
View reviewed changes
denniskigen
denniskigen reviewed Feb 10, 2025
View reviewed changes
@UNCANNY69 UNCANNY69 mentioned this pull request Feb 10, 2025
Open
3 tasks
@UNCANNY69
Copy link
Author

Reated PR:

openmrs/openmrs-esm-patient-chart#2237

@UNCANNY69
Copy link
Author

I made the changes according to the discussion in the JIRA, can it be reviewed again @denniskigen @samuelmale @NethmiRodrigo

@UNCANNY69 UNCANNY69 requested a review from samuelmale February 12, 2025 16:52
@UNCANNY69 UNCANNY69 requested a review from samuelmale April 21, 2025 11:29
vasharma05
vasharma05 reviewed Apr 21, 2025
View reviewed changes
@UNCANNY69 UNCANNY69 requested a review from vasharma05 April 22, 2025 09:55
samuelmale
samuelmale reviewed Apr 22, 2025
View reviewed changes
@UNCANNY69 UNCANNY69 requested a review from samuelmale April 29, 2025 08:14
@UNCANNY69
Copy link
Author

Resolved all the comments can it be reviewed again @denniskigen @samuelmale ?

@denniskigen denniskigen changed the title (feat)O3-2971: Adding conformation modal for an empty form. (feat) O3-2971: Show a confirmation modal when the user submits an empty form Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NethmiRodrigo NethmiRodrigo Awaiting requested review from NethmiRodrigo

@denniskigen denniskigen Awaiting requested review from denniskigen

@vasharma05 vasharma05 Awaiting requested review from vasharma05

@samuelmale samuelmale Awaiting requested review from samuelmale

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@UNCANNY69 @denniskigen @samuelmale @NethmiRodrigo @vasharma05