LUI-208: Fix Node.appendChild error in search results with newer DWR util.js (#240)

The cellCreator function in OpenmrsSearch.js returned options.data directly
when it was already a TD element. The newer DWR util.js (from
org.openmrs.contrib) then calls cell.appendChild(data) on the returned
cell, but since cell === data, this throws 'Node.appendChild: The new
child is an ancestor of the parent' on pages like Find Duplicate Patients
and concept search popups.

Fix: Create a new TD element in cellCreator and transfer all attributes
and child nodes from the original, so the returned cell is always a
different object from the data.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: dkayiwa

omod/src/main/webapp/resources/scripts/dojo/src/widget/openmrs/OpenmrsSearch.js

@@ -573,8 +573,33 @@ dojo.widget.defineWidget(
 	},
 
 	cellCreator: function(options) {
-		if (dwr.util._isHTMLElement(options.data, "td") == true)
-			return options.data;
+		if (dwr.util._isHTMLElement(options.data, "td") == true) {
+			// LUI-208: Create a new td and transfer content from the original.
+			// The newer DWR util.js (from org.openmrs.contrib) always tries to
+			// appendChild(data) on the cell returned by cellCreator. When the
+			// cell IS the data (same object), this causes "Node.appendChild:
+			// The new child is an ancestor of the parent". By returning a
+			// different td object with the same content, we avoid this error.
+			var original = options.data;
+			var td = document.createElement("td");
+			td.className = original.className;
+			td.id = original.id;
+			if (original.colSpan > 1) td.colSpan = original.colSpan;
+			td.onclick = original.onclick;
+			td.onmouseover = original.onmouseover;
+			td.onmouseout = original.onmouseout;
+			while (original.firstChild) {
+				td.appendChild(original.firstChild);
+			}
+			// Clear the original to avoid duplicate ids and stale state
+			// in case DWR appends it as a nested element
+			original.className = '';
+			original.id = '';
+			original.onclick = null;
+			original.onmouseover = null;
+			original.onmouseout = null;
+			return td;
+		}
 
 		return document.createElement("td");
 	},