Skip to content

Conversation

@CanerKaraca23
Copy link
Contributor

  • Update dependencies.
  • Replace deprecated dependencies.
  • Remove unused dependencies.
  • Use latest Node.
  • Use latest cargo.
  • Fix dll-syringe issue.
  • Fix 32 security vulnerabilities.

Works without any issue.

Updating react-native, typescript, @types/react, @tauri-apps/api, @tauri-apps/cli on npm and tauri-build, tauri, interprocess on cargo causes build errors, so i didn't updated them.

@AmyrAhmady
Copy link
Member

Test it on windows 7 and see if it works
otherwise I'm not going to merge it

@CanerKaraca23
Copy link
Contributor Author

Test it on windows 7 and see if it works otherwise I'm not going to merge it

It works fine on Windows 11 24H2, i don't have Windows 7 PC, so... Need someone have Windows 7 to test it.

@itsneufox
Copy link
Contributor

It works fine on Windows 11 24H2

irrelevant to what he asked.

but i did spin up a vm...

imagem

That error usually means we trying to run a program built for a newer version of Windows on an older one. Specifically:

GetSystemTimePreciseAsFileTime is a function only available on Windows 8 or later.

@itsneufox
Copy link
Contributor

Forgot to mention this:
imagem

Latest release works, your PR artifact doesn't.

@itsneufox
Copy link
Contributor

I've been doing some testing and found that nightly Rust has dropped Windows 7 support by switching from GetSystemTimeAsFileTime to GetSystemTimePreciseAsFileTime

imagem

https://releases.rs/docs/1.78.0/

To maintain Windows 7 compatibility, there are a few options:

Stick to Rust 1.77.2 or earlier (the last versions that worked on Windows 7)
Use the new Windows 7 legacy targets (x86_64-win7-windows-msvc/i686-win7-windows-msvc) once they reach Tier 2 support
Find community-provided builds that maintain Windows 7 support

Or just drop windows 7 support althogether

@CanerKaraca23
Copy link
Contributor Author

Thanks for testing. I think i only update npm dependencies, will rebase.

@karimcambridge
Copy link

karimcambridge commented Jul 21, 2025

I do not recommend switching to node-version: latest, please bump the version to the LTS number and not latest.

I don't think I really need to explain why, if it needs be, I will.

@AmyrAhmady Please do not approve unless this change is made.

@CanerKaraca23 you also bumped dependencies that has major version changes, like i18next, did you read all the release notes and ensure compatibility? zustand 5 afaik has breaking changes.

@CanerKaraca23
Copy link
Contributor Author

I do not recommend switching to node-version: latest, please bump the version to the LTS number and not latest.

I don't think I really need to explain why, if it needs be, I will.

@AmyrAhmady Please do not approve unless this change is made.

@CanerKaraca23 you also bumped dependencies that has major version changes, like i18next, did you read all the release notes and ensure compatibility? zustand 5 afaik has breaking changes.

As i said, it's working fine. I use this build on my daily usage.

@CanerKaraca23 CanerKaraca23 closed this by deleting the head repository Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants