Description
Just like what title says, this is an abuse, we are not limited nor restricted to stick with those events. If it was working back then in one 3rd party library, not used widely enough to be our base of opinions and implementations
Inconsistency & making zero sense:
"Call" OnPlayerDisconnect for connected players?!
"Call" OnPlayerConnect for already connected players?
The amount of people reaching out to me because this breaks their single filterscript map file, or an admin script, or anything else is a lot, and the fact that it makes absolutely zero sense (player is already CONNECTED!).
Does player leave your server when you unload a filterscript? No!
Does player just connect to your server when you try to load your filterscript? No!
So why are we making this breakable and unmanageable change to mess with people's scripts? How is it possible to distinguish whether player has just connected to your server, and it's not just a simple filterscript reload/load?
How is any of this related to PLAYER'S CONNECTION? do we do anything on network level when a filterscript gets loaded? I sure hope not!
So what's the solution?
Create two new callbacks/events for that. you load a script, a new event dedicated to that cause gets called, like OnPlayerJoinScript, or OnScriptLoadForPlayer?
Then keep OnPlayerDisconnect and OnPlayerConnect to what they are meant to be used for, to what they are created for, to what they are meant to, the meaning!
Final words, most important ones
This is an issue made for community, I'm asking anyone seeing this to give their opinion on this, consider this a community poll.
If you have nothing to say, use numbers, use + or -, just say +1 or -1.