Fix bug in make_nifti method to handle Path objects correctly #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendhouseart
requested changes
Jan 28, 2025
Contributor
bendhouseart
left a comment
bendhouseart
left a comment
There was a problem hiding this comment.
Nice catch, thanks! I went ahead and did some significant refactoring just now. I would ask that you re-sync your main branch and merge it into mcsitter:path-1. Will hit the squash and merge as soon as that's taken care of.
Contributor
|
Actually that shouldn't matter, it's two small changes. I'm going to send it. |
bendhouseart
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a bug fix in the
pypet2bids/ecat.pyfile and I added myself to thecontributors.mdfile.I modified the
make_niftimethod to correctly check if the output file name ends with "nii.gz" usingpathlib.Path(output).nameinstead of checking the entire path string. Sincepathlib.Pathobjects are not iterable, the"nii.gz" not in outputcheck would otherwise throw a TypeError, ifoutputis not a string but aPathobject. Since providing the nifti_file as a pathlib.Path object does not throw errors in other places of the code, at least when running.convert(), I considered this a bug.📚 Documentation preview 📚: https://pet2bids--333.org.readthedocs.build/en/333/