Skip to content

Conversation

@CPernet
Copy link
Contributor

@CPernet CPernet commented Aug 24, 2025


📚 Documentation preview 📚: https://pet2bids--363.org.readthedocs.build/en/363/

@CPernet CPernet requested a review from Copilot August 24, 2025 06:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for the 3DRP (3D Kinahan-Rogers) reconstruction method while simplifying the metadata structure by removing optional fields when they are not applicable. The changes improve the flexibility of reconstruction method handling by making parameter fields conditional based on whether actual parameters exist.

Key changes:

  • Adds 3DRP reconstruction method to PET metadata definitions
  • Makes ReconMethodParameterUnits and ReconMethodParameterValues conditional fields rather than mandatory
  • Implements dynamic field removal when reconstruction parameters are set to "none"

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
metadata/PET_reconstruction_methods.json Adds 3DRP method definition and removes null parameter fields from existing methods
metadata/PET_metadata.json Moves parameter fields from mandatory to optional and adds ReconFilterSize to recommended
matlab/updatejsonpetfile.m Implements conditional field handling and removes fields when set to "none"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@CPernet CPernet closed this Aug 24, 2025
@CPernet
Copy link
Contributor Author

CPernet commented Aug 24, 2025

the validator does not accept some changes - to be re-checked

@CPernet CPernet self-assigned this Aug 24, 2025
@CPernet CPernet added bug Something isn't working enhancement New feature or request labels Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants