52 pipeline should halt if bad t1ws are present or more generally if not bids valid #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A t1w file not found error would get caught by a try except that's now been fixed by tracking all not found t1w errors and halting the pipeline while alerting the user.
Collaborator
Author
|
Added a validator check using the newer validator to screeeeeaam if the dataset isn't valid. Aka, it will crash on any error returned from |
Collaborator
Author
|
@bendhouseart add test data |
Collaborator
Author
|
@mnoergaard this is gtg |
mnoergaard
approved these changes
Jun 3, 2025
Collaborator
mnoergaard
left a comment
mnoergaard
left a comment
There was a problem hiding this comment.
LGTM - thanks, Anthony!
bendhouseart
deleted the
52-pipeline-should-halt-if-bad-t1ws-are-present-or-more-generally-if-not-bids-valid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #52 and tells the user how to (potentially) fix issues with T1w's or how to ignore them by using the exclude flag for future attempts at defacing.
📚 Documentation preview 📚: https://petdeface--54.org.readthedocs.build/en/54/