-
Notifications
You must be signed in to change notification settings - Fork 16
Open
Labels
component: front-endfeature: mapissue type: bugSomething isn't workingSomething isn't workingjavascriptPull requests that update Javascript codePull requests that update Javascript codestatus: ready to work onPrioritized and ready for a contributor to move to "In Progress"Prioritized and ready for a contributor to move to "In Progress"
Description
Describe the bug
- Too little space between the grid container and the header and footer (overlap, actually).
- The logo isn't aligned and is responsible for too much header padding.
- The nav items are aligned with the bottom of the header, which doesn't match the wireframes
- The map box and map menu are equal-width rectangular columns, which doesn't match the wireframes.
- The font sizes in the map menu don't make sense.
- The "We haven't collected data for this date" alert isn't noticeable because it's far from the datepicker.
To Reproduce
Steps to reproduce the behavior:
- Go to the map page.
- See issues.
Expected behavior
- The grid container should not overlap the header or footer, and it should have more space in between.
- The logo should be less padded and better aligned with the left margin of the grid container.
- The nav items should be at the top of the header.
- The map box should be larger and square, and the map menu should be narrower.
- The map menu font sizes should be hierarchical.
- The "We haven't collected data for this date" alert should be in a more noticeable location.
Desktop (please complete the following information):
- OS: Windows 11
- Browser: Brave
- Version 1.44.101
Additional context
Wireframes: https://www.figma.com/file/YJGrbzkh0dei32uAH3Q5m3/WOAQ?node-id=2619%3A6859
Labels
- Add a status label
needs definitionneeds helpready to work onin progressbacklog
- Add a
buglabel - Add additional labels as needed
Affected Components (For Developers)
Header and map index. Semantic UI defaults were overriding CSS changes I was trying to make, so I'm not sure exactly where the new styles should go.
Technical Resources (For Developers)
- Remove the grid container's negative margin and give it about
3rempadding at the bottom. - Align logo and remove padding around it
- For the nav items, replace
align-self: flex-endwithflex-start. - Give the map box height and width an equal, fixed percentage of something (
60vw?) to make it square, and reduce the map menu width to fit - Fix font sizes in map menu
- Remove
absolutefrom "We haven't collected data for this date" alert and put it adjacent to the datepicker
Metadata
Metadata
Labels
component: front-endfeature: mapissue type: bugSomething isn't workingSomething isn't workingjavascriptPull requests that update Javascript codePull requests that update Javascript codestatus: ready to work onPrioritized and ready for a contributor to move to "In Progress"Prioritized and ready for a contributor to move to "In Progress"