Merge branch 'release/0.29-stable' into 0.29-backports

Author: microstudi

decidim-admin/app/views/decidim/admin/officializations/index.html.erb

@@ -20,8 +20,13 @@
       <tbody>
       <% @users.each do |user| %>
         <tr data-user-id="<%= user.id %>">
-          <td><%= link_to_if user.nickname.present?, user.name, decidim.profile_path(user.nickname) %></td>
-          <td><%= link_to_if user.nickname.present?, user.nickname, decidim.profile_path(user.nickname) %></td>
+          <% if user.nickname.present? %>
+            <td><%= link_to user.name, decidim.profile_path(user.nickname) %></td>
+            <td><%= link_to user.nickname, decidim.profile_path(user.nickname) %></td>
+          <% else %>
+            <td><%= user.name %></td>
+            <td><%= user.nickname %></td>
+          <% end %>
           <td><%= l user.created_at, format: :short %></td>
           <td><%= user.officialized? ? t(".officialized") : t(".not_officialized") %></td>
           <td><%= translated_attribute(user.officialized_as) %></td>

decidim-admin/spec/system/admin_manages_officializations_spec.rb

@@ -66,6 +66,23 @@
     end
   end
 
+  describe "when user's nickname is blank" do
+    let!(:user) { create(:user, :managed, organization:, nickname: "") }
+
+    before do
+      within_admin_sidebar_menu do
+        click_on "Participants"
+      end
+    end
+
+    it "has no user link" do
+      within "tr[data-user-id=\"#{user.id}\"]" do
+        expect(page).to have_content(user.name)
+        expect(page).to have_no_link(user.name)
+      end
+    end
+  end
+
   describe "officializating users" do
     context "when not yet officialized" do
       let!(:user) { create(:user, organization:) }

decidim-core/app/packs/stylesheets/decidim/_author.scss

@@ -14,6 +14,10 @@
 
     &-container {
       @apply rounded-full overflow-hidden inline-block w-6 h-6 align-top;
+
+      &:focus-within {
+        @apply ring-2 ring-primary;
+      }
     }
 
     &-counter {

decidim-verifications/lib/decidim/verifications/adapter.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Verifications
     class InvalidVerificationRoute < StandardError
-      def new(route:)
+      def initialize(route:)
         msg = <<~MSG
           You specified a direct handler but you are trying to use `#{route}`
           which is only available for multi-step authorization workflows. Change
@@ -15,7 +15,7 @@ def new(route:)
     end
 
     class MissingVerificationRoute < StandardError
-      def new(handler:, route:, action:)
+      def initialize(handler:, route:, action:)
         msg = <<~MSG
           The authorization handler `#{handler}` does not define the route
           `#{route}`. If you want to enable `#{action}` for `#{handler}`, change
@@ -27,7 +27,7 @@ def new(handler:, route:, action:)
     end
 
     class MissingEngine < StandardError
-      def new(handler:, engine:)
+      def initialize(handler:, engine:)
         msg = <<~MSG
           The authorization handler `#{handler}` does not define the `#{engine}`
           engine. Please define the engine in the workflow configuration.