linting

Author: microstudi

decidim-meetings/app/events/decidim/meetings/update_meeting_event.rb

@@ -11,9 +11,9 @@ def notification_title
         I18n.t(
           "notification_title",
           scope: i18n_scope,
-          changed_fields: changed_fields,
+          changed_fields:,
           resource_title: translated_attribute(resource.title),
-          resource_path: resource_path
+          resource_path:
         ).html_safe
       end
 

decidim-meetings/spec/commands/admin/copy_meeting_fields_spec.rb

@@ -9,9 +9,9 @@ module Admin
         subject { described_class.new(form, meeting) }
 
         let(:organization) { create(:organization) }
-        let(:participatory_process) { create(:participatory_process, organization: organization) }
+        let(:participatory_process) { create(:participatory_process, organization:) }
         let(:current_component) { create(:component, manifest_name: "meetings", participatory_space: participatory_process) }
-        let(:user) { create(:user, :admin, :confirmed, organization: organization) }
+        let(:user) { create(:user, :admin, :confirmed, organization:) }
         let(:meeting) { create(:meeting, :published, component: current_component, **meeting_attributes) }
 
         let(:meeting_attributes) do

decidim-meetings/spec/commands/join_waitlist_spec.rb

@@ -7,17 +7,17 @@ module Decidim::Meetings
     subject { described_class.new(meeting, form) }
 
     let(:organization) { create(:organization) }
-    let(:participatory_process) { create(:participatory_process, organization: organization) }
+    let(:participatory_process) { create(:participatory_process, organization:) }
     let(:component) { create(:component, manifest_name: :meetings, participatory_space: participatory_process) }
     let(:available_slots) { 2 }
     let(:meeting) do
       create(:meeting,
-             component: component,
+             component:,
              registrations_enabled: true,
-             available_slots: available_slots)
+             available_slots:)
     end
 
-    let(:user) { create(:user, :confirmed, organization: organization, notifications_sending_frequency: "none") }
+    let(:user) { create(:user, :confirmed, organization:, notifications_sending_frequency: "none") }
     let(:form) do
       Decidim::Meetings::JoinMeetingForm.new.with_context(
         current_user: user
@@ -35,7 +35,7 @@ module Decidim::Meetings
 
     context "when all conditions are met" do
       before do
-        create_list(:registration, available_slots, meeting: meeting, status: :registered)
+        create_list(:registration, available_slots, meeting:, status: :registered)
       end
 
       it "broadcasts ok" do
@@ -58,7 +58,7 @@ module Decidim::Meetings
 
     context "when the user is already registered" do
       before do
-        create(:registration, meeting: meeting, user: user, status: :registered)
+        create(:registration, meeting:, user:, status: :registered)
       end
 
       it "broadcasts invalid" do
@@ -74,7 +74,7 @@ module Decidim::Meetings
 
     context "when the form is invalid" do
       before do
-        create_list(:registration, available_slots, meeting: meeting, status: :registered)
+        create_list(:registration, available_slots, meeting:, status: :registered)
         allow(form).to receive(:valid?).and_return(false)
       end
 

decidim-meetings/spec/controllers/decidim/meetings/registrations_controller_spec.rb

@@ -27,7 +27,7 @@ module Decidim::Meetings
         context "with available slots" do
           it "creates registration and redirects" do
             expect do
-              post :create, params: params
+              post :create, params:
             end.to change(Registration, :count).by(1)
 
             expect(flash[:notice]).to eq(I18n.t("registrations.create.success", scope: "decidim.meetings"))
@@ -36,10 +36,10 @@ module Decidim::Meetings
         end
 
         context "when no available slots" do
-          let!(:registrations) { create_list(:registration, 10, meeting: meeting) }
+          let!(:registrations) { create_list(:registration, 10, meeting:) }
 
           it "shows error message" do
-            post :create, params: params
+            post(:create, params:)
 
             expect(flash[:alert]).to eq(I18n.t("registrations.create.invalid", scope: "decidim.meetings"))
             expect(response).to redirect_to(meeting_path(meeting))
@@ -49,7 +49,7 @@ module Decidim::Meetings
 
       context "when user not authenticated" do
         it "redirects to login" do
-          post :create, params: params
+          post(:create, params:)
           expect(response).to redirect_to("/users/sign_in")
         end
       end
@@ -76,15 +76,15 @@ module Decidim::Meetings
         meeting.update!(
           registrations_enabled: true,
           registration_form_enabled: true,
-          questionnaire: questionnaire
+          questionnaire:
         )
       end
 
       context "with valid params" do
         context "when joining directly" do
           it "answers questionnaire and redirects" do
             expect do
-              post :respond, params: params
+              post :respond, params:
             end.to change { meeting.registrations.count }.by(1)
 
             expect(flash[:notice]).to eq(I18n.t("registrations.create.success", scope: "decidim.meetings"))
@@ -94,11 +94,11 @@ module Decidim::Meetings
 
         context "when joining waitlist" do
           let(:meeting) { create(:meeting, component:, available_slots: 10) }
-          let!(:registrations) { create_list(:registration, 10, meeting: meeting) }
+          let!(:registrations) { create_list(:registration, 10, meeting:) }
 
           it "adds user to waitlist and redirects" do
             expect do
-              post :respond, params: params
+              post :respond, params:
             end.to change { meeting.registrations.where(status: :waiting_list).count }.by(1)
 
             expect(flash[:notice]).to eq(I18n.t("registrations.waitlist.success", scope: "decidim.meetings"))
@@ -116,7 +116,7 @@ module Decidim::Meetings
         end
 
         it "shows error message" do
-          post :respond, params: params
+          post(:respond, params:)
 
           expect(flash[:alert]).to eq(I18n.t("response.invalid", scope: "decidim.forms.questionnaires"))
           expect(response).to render_template("decidim/forms/questionnaires/show")
@@ -126,15 +126,15 @@ module Decidim::Meetings
 
     describe "POST join_waitlist" do
       let(:meeting) { create(:meeting, component:, available_slots: 10) }
-      let!(:registrations) { create_list(:registration, 10, meeting: meeting) }
+      let!(:registrations) { create_list(:registration, 10, meeting:) }
       let(:params) { { meeting_id: meeting.id } }
 
       before { sign_in user }
 
       context "when meeting has no available slots" do
         it "adds user to waitlist" do
           expect do
-            post :join_waitlist, params: params
+            post :join_waitlist, params:
           end.to change(Registration.on_waiting_list, :count).by(1)
 
           expect(flash[:notice]).to eq(I18n.t("registrations.waitlist.success", scope: "decidim.meetings"))
@@ -151,7 +151,7 @@ module Decidim::Meetings
 
       it "destroys registration" do
         expect do
-          delete :destroy, params: params
+          delete :destroy, params:
         end.to change(Registration, :count).by(-1)
 
         expect(flash[:notice]).to match(/successfully/)

decidim-meetings/spec/forms/admin/meeting_form_spec.rb

@@ -189,7 +189,7 @@ module Decidim::Meetings
 
       expect(described_class.from_model(meeting).decidim_category_id).to eq(category_id)
     end
-    
+
     describe "when reminder_enabled is false" do
       let(:reminder_enabled) { false }
 
@@ -221,6 +221,7 @@ module Decidim::Meetings
         it { is_expected.to be_valid }
       end
     end
+
     describe "services_to_persist" do
       subject { form.services_to_persist }
 

decidim-meetings/spec/system/admin/admin_manages_meetings_spec.rb

@@ -340,7 +340,7 @@
     visit decidim_admin.root_path
     expect(page).to have_content("created the #{translated(attributes[:title])} meeting on the")
   end
-  
+
   context "when the venue has not been decided yet" do
     it "creates a new meeting without an address" do
       click_on "New meeting"

decidim-meetings/spec/system/meeting_waiting_list_spec.rb

@@ -58,7 +58,7 @@ def leave_meeting(user)
 
     context "when the meeting has no available slots" do
       before do
-        create_list(:registration, available_slots, meeting: meeting)
+        create_list(:registration, available_slots, meeting:)
       end
 
       context "when the user is not logged in" do
@@ -111,13 +111,13 @@ def leave_meeting(user)
 
   context "when the meeting is full and a user cancels their registration" do
     context "and there are users on the waiting list" do
-      let!(:registrations) { create_list(:registration, available_slots, meeting: meeting) }
+      let!(:registrations) { create_list(:registration, available_slots, meeting:) }
       let(:users_on_waitlist) { create_list(:user, 5, :confirmed, organization:) }
       let(:first_waitlist_user) { users_on_waitlist.first }
 
       let!(:waitlist_entries) do
         users_on_waitlist.map.with_index do |user, index|
-          create(:registration, meeting: meeting, user: user, status: "waiting_list", created_at: Time.current - index.minutes)
+          create(:registration, meeting:, user:, status: "waiting_list", created_at: Time.current - index.minutes)
         end
       end