Apply recipe best practices

Author: timtebeek

src/main/java/org/openrewrite/maven/ConfigurableRewriteMojo.java

@@ -35,9 +35,7 @@
 import java.nio.file.Paths;
 import java.util.*;
 
-import static java.util.Collections.emptyMap;
-import static java.util.Collections.emptySet;
-import static java.util.Collections.unmodifiableSet;
+import static java.util.Collections.*;
 import static java.util.stream.Collectors.toCollection;
 import static org.openrewrite.java.style.CheckstyleConfigLoader.loadCheckstyleConfig;
 

src/test/java/org/openrewrite/maven/RewriteRunIT.java

@@ -52,8 +52,8 @@ void multi_source_sets_project(MavenExecutionResult result) {
           .isSuccessful()
           .out()
           .warn()
-          .contains(String.format("Changes have been made to %s by:", separatorsToSystem("project/src/integration-test/java/sample/IntegrationTest.java")))
-          .contains(String.format("Changes have been made to %s by:", separatorsToSystem("project/src/test/java/sample/RegularTest.java")));
+          .contains("Changes have been made to %s by:".formatted(separatorsToSystem("project/src/integration-test/java/sample/IntegrationTest.java")))
+          .contains("Changes have been made to %s by:".formatted(separatorsToSystem("project/src/test/java/sample/RegularTest.java")));
     }
 
     @MavenTest
@@ -100,7 +100,7 @@ void cloud_suitability_project(MavenExecutionResult result) {
     void command_line_options(MavenExecutionResult result) {
         assertThat(result).isSuccessful().out().error().isEmpty();
         assertThat(result).isSuccessful().out().warn()
-          .contains(String.format("Changes have been made to %s by:", separatorsToSystem("project/pom.xml")))
+          .contains("Changes have been made to %s by:".formatted(separatorsToSystem("project/pom.xml")))
           .contains("    org.openrewrite.maven.RemovePlugin: {groupId=org.openrewrite.maven, artifactId=rewrite-maven-plugin}");
         assertThat(result.getMavenProjectResult().getModel().getBuild()).isNull();
     }
@@ -116,7 +116,7 @@ void command_line_options_json(MavenExecutionResult result) {
           .isSuccessful()
           .out()
           .warn()
-          .contains(String.format("Changes have been made to %s by:", separatorsToSystem("project/src/main/java/sample/SomeClass.java")))
+          .contains("Changes have been made to %s by:".formatted(separatorsToSystem("project/src/main/java/sample/SomeClass.java")))
           .contains("    org.openrewrite.java.AddCommentToMethod: {comment='{\"test\":{\"some\":\"yeah\"}}', methodPattern=sample.SomeClass doTheThing(..)}");
     }
 
@@ -148,10 +148,10 @@ void container_masks(MavenExecutionResult result) {
           .out()
           .warn()
           .contains(
-            String.format("Changes have been made to %s by:", separatorsToSystem("project/containerfile.build")),
-            String.format("Changes have been made to %s by:", separatorsToSystem("project/Dockerfile")),
-            String.format("Changes have been made to %s by:", separatorsToSystem("project/Containerfile")),
-            String.format("Changes have been made to %s by:", separatorsToSystem("project/build.dockerfile"))
+                "Changes have been made to %s by:".formatted(separatorsToSystem("project/containerfile.build")),
+                "Changes have been made to %s by:".formatted(separatorsToSystem("project/Dockerfile")),
+                "Changes have been made to %s by:".formatted(separatorsToSystem("project/Containerfile")),
+                "Changes have been made to %s by:".formatted(separatorsToSystem("project/build.dockerfile"))
           );
     }
 
@@ -163,10 +163,10 @@ void plaintext_masks(MavenExecutionResult result) {
           .out()
           .warn()
           .contains(
-            String.format("Changes have been made to %s by:", separatorsToSystem("project/src/main/java/sample/in-src.ext")),
-            String.format("Changes have been made to %s by:", separatorsToSystem("project/.in-root")),
-            String.format("Changes have been made to %s by:", separatorsToSystem("project/from-default-list.py")),
-            String.format("Changes have been made to %s by:", separatorsToSystem("project/src/main/java/sample/Dummy.java"))
+                  "Changes have been made to %s by:".formatted(separatorsToSystem("project/src/main/java/sample/in-src.ext")),
+                  "Changes have been made to %s by:".formatted(separatorsToSystem("project/.in-root")),
+                  "Changes have been made to %s by:".formatted(separatorsToSystem("project/from-default-list.py")),
+                  "Changes have been made to %s by:".formatted(separatorsToSystem("project/src/main/java/sample/Dummy.java"))
           )
           .doesNotContain("in-root.ignored");
     }

src/test/java/org/openrewrite/maven/RewriteTypeTableIT.java

@@ -17,7 +17,6 @@
 
 import com.soebes.itf.jupiter.extension.*;
 import com.soebes.itf.jupiter.maven.MavenExecutionResult;
-import org.openrewrite.PathUtils;
 
 import static com.soebes.itf.extension.assertj.MavenITAssertions.assertThat;
 import static org.openrewrite.PathUtils.separatorsToSystem;
@@ -38,7 +37,7 @@ void typetable_default(MavenExecutionResult result) {
             "contains guava 33.3.1-jre")
           .matches(logLines -> logLines.stream().anyMatch(line -> line.contains("Wrote com.google.guava:guava:jar:32.0.0-jre")),
             "contains guava 32.0.0-jre")
-          .matches(logLines -> logLines.stream().anyMatch(line -> line.contains(String.format("Wrote %s", separatorsToSystem("src/main/resources/META-INF/rewrite/classpath.tsv.gz")))),
+          .matches(logLines -> logLines.stream().anyMatch(line -> line.contains("Wrote %s".formatted(separatorsToSystem("src/main/resources/META-INF/rewrite/classpath.tsv.gz")))),
             "write classpath.tsv.gz");
         assertThat(result).out().error().isEmpty();
     }