Address review comments

Author: shanman190

rewrite-core/src/main/java/org/openrewrite/marketplace/RecipeBundleReader.java

@@ -18,11 +18,9 @@
 import org.openrewrite.Recipe;
 import org.openrewrite.config.RecipeDescriptor;
 
-import java.io.Closeable;
-import java.io.IOException;
 import java.util.Map;
 
-public interface RecipeBundleReader extends Closeable {
+public interface RecipeBundleReader extends AutoCloseable {
     RecipeBundle getBundle();
 
     RecipeMarketplace read();
@@ -31,7 +29,7 @@ public interface RecipeBundleReader extends Closeable {
 
     Recipe prepare(RecipeListing listing, Map<String, Object> options);
 
-    default void close() throws IOException {
+    default void close() throws Exception {
         // no-op
     }
 }

rewrite-core/src/main/java/org/openrewrite/marketplace/RecipeBundleResolver.java

@@ -15,15 +15,12 @@
  */
 package org.openrewrite.marketplace;
 
-import java.io.Closeable;
-import java.io.IOException;
-
-public interface RecipeBundleResolver extends Closeable {
+public interface RecipeBundleResolver extends AutoCloseable {
     String getEcosystem();
 
     RecipeBundleReader resolve(RecipeBundle bundle);
 
-    default void close() throws IOException {
+    default void close() throws Exception {
         // no-op
     }
 }

rewrite-core/src/main/java/org/openrewrite/marketplace/RecipeListing.java

@@ -66,7 +66,7 @@ public class RecipeListing implements Comparable<RecipeListing> {
     @With(AccessLevel.PACKAGE)
     private final RecipeBundle bundle;
 
-    private RecipeBundleReader resolve(List<RecipeBundleResolver> resolvers) {
+    private RecipeBundleReader resolve(Collection<RecipeBundleResolver> resolvers) {
         for (RecipeBundleResolver resolver : resolvers) {
             if (resolver.getEcosystem().equals(bundle.getPackageEcosystem())) {
                 return resolver.resolve(bundle);
@@ -75,11 +75,13 @@ private RecipeBundleReader resolve(List<RecipeBundleResolver> resolvers) {
         throw new IllegalStateException(String.format("No available resolver for '%s' ecosystem", bundle.getPackageEcosystem()));
     }
 
-    public RecipeDescriptor describe(List<RecipeBundleResolver> resolvers) {
+    public RecipeDescriptor describe(Collection<RecipeBundleResolver> resolvers) {
+        // noinspection resource
         return resolve(resolvers).describe(this);
     }
 
-    public Recipe prepare(List<RecipeBundleResolver> resolvers, Map<String, Object> options) {
+    public Recipe prepare(Collection<RecipeBundleResolver> resolvers, Map<String, Object> options) {
+        // noinspection resource
         return resolve(resolvers).prepare(this, options);
     }
 

rewrite-core/src/test/java/org/openrewrite/rpc/RewriteRpcTest.java

@@ -37,10 +37,10 @@
 import java.io.IOException;
 import java.io.PipedInputStream;
 import java.io.PipedOutputStream;
+import java.util.List;
 import java.util.Map;
 import java.util.concurrent.CountDownLatch;
 
-import static java.util.Collections.singletonList;
 import static java.util.Objects.requireNonNull;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.openrewrite.marketplace.RecipeBundle.runtimeClasspath;
@@ -71,7 +71,7 @@ void before() throws IOException {
         client = new RewriteRpc(new JsonRpc(new HeaderDelimitedMessageHandler(clientFormatter, clientIn, clientOut)), marketplace)
           .batchSize(1);
 
-        server = new RewriteRpc(new JsonRpc(new HeaderDelimitedMessageHandler(serverFormatter, serverIn, serverOut)), marketplace, singletonList(new TestRecipeBundleResolver()))
+        server = new RewriteRpc(new JsonRpc(new HeaderDelimitedMessageHandler(serverFormatter, serverIn, serverOut)), marketplace, List.of(new TestRecipeBundleResolver()))
           .batchSize(1);
     }
 

rewrite-maven/src/main/java/org/openrewrite/maven/marketplace/MavenRecipeBundleResolver.java

@@ -27,7 +27,6 @@
 import org.openrewrite.maven.tree.Scope;
 import org.openrewrite.maven.utilities.MavenArtifactDownloader;
 
-import java.io.IOException;
 import java.util.Optional;
 
 public class MavenRecipeBundleResolver implements RecipeBundleResolver {
@@ -91,7 +90,7 @@ private Optional<MavenResolutionResult> resolveDependencies(GroupArtifactVersion
     }
 
     @Override
-    public void close() throws IOException {
+    public void close() throws Exception {
         if (reader != null) {
             reader.close();
         }