Skip to content

Commit cda3f82

Browse files
committed
Add comment clarify the test since it is a bit of an edge case in Maven behavior
1 parent fae1563 commit cda3f82

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

rewrite-maven/src/test/java/org/openrewrite/maven/MavenParserTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4874,13 +4874,18 @@ void diamondProblem() {
48744874
<artifactId>parent</artifactId>
48754875
<packaging>pom</packaging>
48764876
<properties>
4877+
<!-- This property becomes inert as a result of the below managed dependency -->
48774878
<bouncycastle.version>1.68</bouncycastle.version>
48784879
</properties>
48794880
<dependencyManagement>
48804881
<dependencies>
48814882
<dependency>
48824883
<groupId>org.bouncycastle</groupId>
48834884
<artifactId>bcprov-jdk18on</artifactId>
4885+
<!--
4886+
1. Managed dependencies DO NOT have their properties merged together. A new managed dependency, completely overlays everything that came before it.
4887+
2. A version-less managed dependency results in no version recommendations being applied
4888+
-->
48844889
</dependency>
48854890
</dependencies>
48864891
</dependencyManagement>

0 commit comments

Comments
 (0)