`Jenkinsfile` changed by `UpgradeToJava17` / `RemoveTrailingWhitespace` recipes

[ammachado]

What version of OpenRewrite are you using?

I am using:

• OpenRewrite v8.11.1
• Maven/Gradle plugin v5.15.4

How are you running OpenRewrite?

I am using the Maven plugin, and my project is a single module project. I'm running the plugin via Maven CLI.

mvn org.openrewrite.maven:rewrite-maven-plugin:5.15.4:dryRunNoFork -Drewrite.recipeArtifactCoordinates=my.company:migration-recipes:1.0.0-SNAPSHOT -Drewrite.activeRecipes=my.company.MigrationRecipe

What is the smallest, simplest way to reproduce the problem?

My project contains the following Jenkinsfile, among other code:

@Library("jenkins-shared-libs@my_tag") _

// artifactory standard pipeline
artifactory()

What did you expect to see?

No changes to Jenkinsfile.

What did you see instead?

[WARNING] These recipes would make changes to Jenkinsfile:
[WARNING]     my.company.MigrationRecipe
[WARNING]         my.company.ProjectTypeAMigrationRecipe
[WARNING]             my.company.CommonRecipe
[WARNING]                 my.company.Java17Recipes
[WARNING]                     org.openrewrite.java.migrate.UpgradeToJava17
[WARNING]                         org.openrewrite.java.migrate.Java8toJava11
[WARNING]                             org.openrewrite.java.migrate.JavaVersion11
[WARNING]                                 org.openrewrite.java.migrate.UpgradeJavaVersion: {version=11}
[WARNING]                         org.openrewrite.java.migrate.JavaVersion17
[WARNING]                             org.openrewrite.java.migrate.UpgradeJavaVersion: {version=17}
[WARNING]             my.company.BestPractices
[WARNING]                 org.openrewrite.java.format.RemoveTrailingWhitespace

diff --git a/Jenkinsfile b/Jenkinsfile
index ed6e76b..2c86077 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -1,4 +1,4 @@ org.openrewrite.config.CompositeRecipe
-@Library("jenkins-shared-libs@my_tag") _
+@Library("jenkins-shared-libs@my_

What is the full stack trace of any errors you encountered?

No stack trace available

Are you interested in contributing a fix to OpenRewrite?

I'm already contributing on other issues.

[timtebeek]

Replicated indeed with a test

@Test
void jenkinsFileWithLibrary() {
    rewriteRun(
      groovy(
        """
          @Library("jenkins-shared-libs@my_tag") _
          
          // artifactory standard pipeline
          artifactory()
          """,
        spec -> spec.path("Jenkinsfile")
      )
    );
}

What's interesting here is that it fails whenever the variable name assigned to the library occurs on the same line. If you remove _ from my_tag the test passes; same thing if you replace the last _ with foo. It's not specific to _ either. It fails just the same if you replace _ with a.

[ammachado]

I did some digging on this one, and it seems that the problem is here: https://github.com/openrewrite/rewrite/blob/main/rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java#L2072. I think it should consider the scope of the quotes.

[ammachado]

Any updates on this one?

[timtebeek]

No updates from my side, although I've also been off for a couple weeks, with some more travel ahead. It seems you've pinpointed the issue already. Are you considering any code changes there already? Or should we tag other folks while I'm out?