Support parsing `module-info.java`

[koppor]

I am using https://app.moderne.io/ (and also locally)

Go to https://app.moderne.io/, select "JabRef" and run org.openrewrite.java.logging.slf4j.ParameterizedLogging

There are 0 results reported:

However, there should be more than 1:

That source code is also available at https://github.com/jabref/jabref/.

[koppor]

I tried

  - org.openrewrite.java.logging.slf4j.Slf4jBestPractices
  - org.openrewrite.java.logging.ParameterizedLogging:
      methodPattern: org.slf4j.Logger error(..)

The latter to match the original PR content. Still no changes applied to the code base.

I asked at https://rewriteoss.slack.com/archives/C01A843MWG5/p1704459019395649 for a end-to-end test. So that one can set breakpoints and see how the whole system behaves. Currently, I am not able to set a breakpoint in the recipe and debug it with my code base.

[timtebeek]

Turns out the issue is caused by missing type information, as explored through the platform:
https://app.moderne.io/recipes/org.openrewrite.java.search.FindMissingTypes

We should figure out why those types are missing, and that will then likely also solve recipe runs against those classes.

[koppor]

For the record an example:

[koppor]

The output of the gradle plugin is pretty clear:

Using active styles [org.openrewrite.java.Checkstyle]
Failed to resolve dependencies from ::implementation. Some type information may be incomplete
Failed to resolve dependencies from ::testImplementation. Some type information may be incomplete

---

Maybe related, when running org.openrewrite.java.testing.junit5.JUnit5BestPractices in moderne (https://app.moderne.io/results/gEbQC3pSP), I get

io.moderne.worker.RecipeLoadingException: io.moderne.worker.ModularizedRecipeLoader$RecipeDependencyLoadException: Failed to resolve recipe dependencies.
Caused by io.moderne.worker.ModularizedRecipeLoader$RecipeDependencyLoadException: Failed to resolve recipe dependencies.
Caused by org.openrewrite.maven.MavenDownloadingExceptions: null
  org.openrewrite.maven.MavenDownloadingExceptions.append(MavenDownloadingExceptions.java:44)
  org.openrewrite.maven.tree.MavenResolutionResult.resolveDependencies(MavenResolutionResult.java:179)
  org.openrewrite.maven.MavenParser.parseInputs(MavenParser.java:113)
  org.openrewrite.Parser.parse(Parser.java:80)
  org.openrewrite.maven.MavenParser.parse(MavenParser.java:55)

(Maybe kind of follow-up to openrewrite/rewrite-testing-frameworks#428)

[timtebeek]

Thanks for that helpful hint @koppor ! It seems the issue arises on these lines then:
https://github.com/openrewrite/rewrite-gradle-plugin/blob/4300cda451aed798c9f099c4b87ba54df6251c95/plugin/src/main/java/org/openrewrite/gradle/isolated/DefaultProjectParser.java#L1048-L1055

We unhelpfully do not log what exception triggered that; perhaps we should to help fix this issue for you, as I have no idea why it would fail now. Perhaps you can add ,e at the end of line 1053, call ./gradlew pTML and then use Gradle plugin 6.7.0-SNAPSHOT to get the stacktrace?

[koppor]

For googlers/noobs:

• ./gradlew pTML means ./gradlew publishToMavenLocal - fun fact: Even ChatGPT did not know
• Ensure, your settings.gradle file contains mavenLocal() in pluginManagement { repositories { ... } }

---

I get the patch to compile and included. However, the issue does NOT appear locally, only on Moderne. I think, I cannot deploy code to there. 🤣🤣

Interestingly, Moderne points to org.openrewrite.maven.MavenParser, but we are on gradle. For sure, a Maven parser is not able to parse Gradle files. How to tell Moderne that this is a gradle project?

[timtebeek]

I'd missed that detail! You're absolutely right that this fails in a Moderne worker. 🙃
Quite curious case as well, since we should just have that recipe in Moderne.

I've reran the recipe just now without issue though, so perhaps it was a one time issue?
https://app.moderne.io/results/YWGK2PQJW/details/eyJfX3R5cGVuYW1lIjoiR2l0SHViUmVwb3NpdG9yeSIsIm9yaWdpbiI6ImdpdGh1Yi5jb20iLCJwYXRoIjoiSmFiUmVmL2phYnJlZiIsImJyYW5jaCI6Im1haW4ifQ==?referrer=https%3A%2F%2Fapp.moderne.io%2Fresults%2FYWGK2PQJW

[koppor]

Result of today: 913 classes w/ missing type information:

https://app.moderne.io/results/JcIPoMVit

[koppor]

I did not see any exception today. (I should have screenshotted where to find a potential exception)