-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure TCCL in InMemoryLargeSourceSet
to enable ServiceLoader
#5034
base: main
Are you sure you want to change the base?
Conversation
…`ClassLoader` to enable `ServiceLoader` to find `Provider`s loaded by recipe `ClassLoader`s
rewrite-gradle/src/test/java/org/openrewrite/gradle/AddDependencyTest.java
Outdated
Show resolved
Hide resolved
rewrite-gradle/src/test/java/org/openrewrite/gradle/AddDependencyTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
78f07e0
to
2eed22c
Compare
2eed22c
to
eacff9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-hcl/src/main/java/org/openrewrite/hcl/format/TabsAndIndentsVisitor.java
- lines 255-256
- rewrite-hcl/src/main/java/org/openrewrite/hcl/internal/HclPrinter.java
- lines 363-364
- rewrite-java/src/main/java/org/openrewrite/java/internal/template/AnnotationTemplateGenerator.java
- lines 158-159
- rewrite-java/src/main/java/org/openrewrite/java/internal/template/BlockStatementTemplateGenerator.java
- lines 281-282
- lines 669-669
- rewrite-java/src/main/java/org/openrewrite/java/search/FindEmptyClasses.java
- lines 57-57
- rewrite-xml/src/main/java/org/openrewrite/xml/internal/XmlPrinter.java
- lines 106-106
- rewrite-yaml/src/main/java/org/openrewrite/yaml/cleanup/RemoveUnusedVisitor.java
- lines 76-76
rewrite-core/src/main/java/org/openrewrite/internal/InMemoryLargeSourceSet.java
Outdated
Show resolved
Hide resolved
Let's also adjust the PR description to reflect the new implementation. |
ClassLoader
in ServiceLoader
InMemoryLargeSurceSe
t to enable ServiceLoader
InMemoryLargeSurceSe
t to enable ServiceLoader
InMemoryLargeSurceSet
to enable ServiceLoader
…hild class loaders until the first result is found
rewrite-java/src/main/java/org/openrewrite/java/CompositClassLoader.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-core/src/main/java/org/openrewrite/ExecutionContext.java
- lines 124-125
- lines 136-138
- lines 149-151
- lines 160-160
- lines 168-168
- rewrite-core/src/main/java/org/openrewrite/Validated.java
- lines 18-18
- lines 166-166
- lines 333-333
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-core/src/main/java/org/openrewrite/ExecutionContext.java
- lines 124-125
- lines 136-138
- lines 149-151
- lines 160-160
- lines 168-168
- rewrite-core/src/main/java/org/openrewrite/Validated.java
- lines 18-18
- lines 166-166
- lines 333-333
InMemoryLargeSurceSet
to enable ServiceLoader
InMemoryLargeSourceSet
to enable ServiceLoader
What's changed?
Forward ClassLoader to SourceFileWithReferences to enbale the used ServiceLoader to load classes from the recipe classpath.
What's your motivation?
Make Providers available that are defined in external recipe artifacts loaded at runtime.
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist