session reset cleanup, footer

Author: monneyboi

poliloom-gui/src/app/stats/page.tsx

@@ -181,12 +181,10 @@ function EvaluationsChart({ data }: { data: EvaluationTimeseriesPoint[] }) {
 function CoverageBar({ item }: { item: CountryCoverage }) {
   const evaluatedPercent =
     item.total_count > 0 ? (item.evaluated_count / item.total_count) * 100 : 0
-  const enrichedNotEvaluated = item.enriched_count - item.evaluated_count
-  const enrichedNotEvaluatedPercent =
-    item.total_count > 0 ? (enrichedNotEvaluated / item.total_count) * 100 : 0
-  const barWidth = evaluatedPercent + enrichedNotEvaluatedPercent
+  const enrichedPercent = item.total_count > 0 ? (item.enriched_count / item.total_count) * 100 : 0
+  const barWidth = enrichedPercent
   const countLabel = `${item.enriched_count} / ${item.total_count}`
-  const percentLabel = `${item.evaluated_count} evaluated (${Math.round(evaluatedPercent)}%), ${enrichedNotEvaluated} processed (${Math.round(enrichedNotEvaluatedPercent)}%)`
+  const percentLabel = `${item.evaluated_count} evaluated (${Math.round(evaluatedPercent)}%), ${item.enriched_count} processed (${Math.round(enrichedPercent)}%)`
 
   const labels = (
     <>

poliloom-gui/src/components/ui/Footer.tsx

@@ -10,6 +10,13 @@ export function Footer() {
       <Button href="https://www.opensanctions.org/impressum/" variant="secondary" size="small">
         Impressum
       </Button>
+      <Button
+        href="https://github.com/opensanctions/poliloom/issues"
+        variant="secondary"
+        size="small"
+      >
+        Issues
+      </Button>
       <Button
         href={WIKIDATA_CONTRIBUTIONS_URL}
         variant="secondary"

poliloom-gui/src/contexts/EvaluationSessionContext.test.tsx

@@ -0,0 +1,87 @@
+import { describe, it, expect, vi, beforeEach } from 'vitest'
+import { renderHook, act, waitFor } from '@testing-library/react'
+import { EvaluationSessionProvider, useEvaluationSession } from './EvaluationSessionContext'
+import { mockPolitician } from '@/test/mock-data'
+import { Politician } from '@/types'
+
+// Mock useAuthSession
+vi.mock('@/hooks/useAuthSession', () => ({
+  useAuthSession: () => ({
+    session: { accessToken: 'mock-token' },
+    status: 'authenticated',
+    isAuthenticated: true,
+  }),
+}))
+
+// Mock UserPreferencesContext with STABLE references to avoid infinite loops
+// The context has a useEffect that clears politicians when filters change,
+// and useMemo depends on filters - so a new array each render causes loops
+const stableFilters: never[] = []
+vi.mock('./UserPreferencesContext', () => ({
+  useUserPreferences: () => ({
+    filters: stableFilters,
+    initialized: true,
+  }),
+}))
+
+// Create a second mock politician for testing advancement
+const mockPolitician2: Politician = {
+  ...mockPolitician,
+  id: 'pol-2',
+  name: 'Second Politician',
+  wikidata_id: 'Q123456',
+}
+
+describe('EvaluationSessionContext', () => {
+  beforeEach(() => {
+    vi.clearAllMocks()
+
+    // Setup mock fetch - always returns same politicians (stable response)
+    // has_enrichable_politicians: false prevents auto-polling
+    global.fetch = vi.fn().mockImplementation((url: string) => {
+      if (url.includes('/api/evaluations/politicians')) {
+        return Promise.resolve({
+          ok: true,
+          json: async () => ({
+            politicians: [mockPolitician, mockPolitician2],
+            meta: { has_enrichable_politicians: false, total_matching_filters: 10 },
+          }),
+        })
+      }
+      if (url.includes('/api/evaluations')) {
+        return Promise.resolve({
+          ok: true,
+          json: async () => ({ success: true, message: 'OK', errors: [] }),
+        })
+      }
+      return Promise.resolve({ ok: false })
+    }) as unknown as typeof fetch
+  })
+
+  it('advances to next politician when session is reset', async () => {
+    const wrapper = ({ children }: { children: React.ReactNode }) => (
+      <EvaluationSessionProvider>{children}</EvaluationSessionProvider>
+    )
+
+    const { result } = renderHook(() => useEvaluationSession(), { wrapper })
+
+    // Wait for initial load
+    await waitFor(() => {
+      expect(result.current.currentPolitician).not.toBeNull()
+    })
+
+    // Verify we start with first politician and have next pre-fetched
+    expect(result.current.currentPolitician?.id).toBe('pol-1')
+    expect(result.current.nextPolitician?.id).toBe('pol-2')
+    expect(result.current.completedCount).toBe(0)
+
+    // Reset the session (simulating "Start new round" on unmount)
+    act(() => {
+      result.current.resetSession()
+    })
+
+    // After reset, next politician should be promoted to current
+    expect(result.current.currentPolitician?.id).toBe('pol-2')
+    expect(result.current.completedCount).toBe(0)
+  })
+})

poliloom-gui/src/contexts/EvaluationSessionContext.tsx

@@ -242,7 +242,8 @@ export function EvaluationSessionProvider({ children }: { children: React.ReactN
 
   const resetSession = useCallback(() => {
     setCompletedCount(0)
-  }, [])
+    advanceToNextPolitician()
+  }, [advanceToNextPolitician])
 
   const value: EvaluationSessionContextType = {
     currentPolitician,