enrichment check and states

Author: monneyboi

poliloom-gui/src/app/evaluate/page.test.tsx

@@ -51,43 +51,39 @@ describe('Evaluate Page', () => {
       render(<EvaluatePage />)
     })
 
-    expect(screen.getByText('Loading politician data...')).toBeInTheDocument()
+    expect(screen.getByText('Finding politicians...')).toBeInTheDocument()
     expect(screen.getByText('Header')).toBeInTheDocument()
   })
 
-  it('shows no politicians message when not loading and no politician available', async () => {
-    const mockLoadPoliticians = vi.fn()
+  it('shows all caught up message when no politicians and nothing to enrich', async () => {
     mockUseEvaluationSession.mockReturnValue({
       currentPolitician: null,
       nextPolitician: null,
       loading: false,
-      enrichmentMeta: { is_enriching: false, total_matching_filters: 0 },
+      enrichmentMeta: { has_enrichable_politicians: false, total_matching_filters: 0 },
       completedCount: 0,
       sessionGoal: 1,
       isSessionComplete: false,
       submitEvaluation: vi.fn(),
       skipPolitician: vi.fn(),
       resetSession: vi.fn(),
-      loadPoliticians: mockLoadPoliticians,
+      loadPoliticians: vi.fn(),
     })
 
     await act(async () => {
       render(<EvaluatePage />)
     })
 
-    expect(
-      screen.getByText(/No politicians available for your current filters/),
-    ).toBeInTheDocument()
-    expect(screen.getByText('filters')).toBeInTheDocument()
-    expect(screen.getByText('reload')).toBeInTheDocument()
+    expect(screen.getByText("You're all caught up!")).toBeInTheDocument()
+    expect(screen.getByText('Start New Session')).toBeInTheDocument()
   })
 
-  it('shows enriching spinner when no politician but enrichment is running', async () => {
+  it('shows loading state when no politician but more can be enriched', async () => {
     mockUseEvaluationSession.mockReturnValue({
       currentPolitician: null,
       nextPolitician: null,
       loading: false,
-      enrichmentMeta: { is_enriching: true, total_matching_filters: 0 },
+      enrichmentMeta: { has_enrichable_politicians: true, total_matching_filters: 0 },
       completedCount: 0,
       sessionGoal: 1,
       isSessionComplete: false,
@@ -101,7 +97,7 @@ describe('Evaluate Page', () => {
       render(<EvaluatePage />)
     })
 
-    expect(screen.getByText('Enriching politician data...')).toBeInTheDocument()
+    expect(screen.getByText('Finding politicians...')).toBeInTheDocument()
   })
 
   it('shows PoliticianEvaluation component when politician data is available', async () => {

poliloom-gui/src/app/evaluate/page.tsx

@@ -5,15 +5,15 @@ import { useRouter } from 'next/navigation'
 import { Header } from '@/components/layout/Header'
 import { PoliticianEvaluation } from '@/components/evaluation/PoliticianEvaluation'
 import { useEvaluationSession } from '@/contexts/EvaluationSessionContext'
-import { Loader } from '@/components/ui/Spinner'
+import { CenteredCard } from '@/components/ui/CenteredCard'
+import { Button } from '@/components/ui/Button'
+import { Spinner } from '@/components/ui/Spinner'
 import { useTutorial } from '@/contexts/TutorialContext'
 import { useUserPreferences } from '@/contexts/UserPreferencesContext'
-import Link from 'next/link'
 
 export default function EvaluatePage() {
   const router = useRouter()
-  const { currentPolitician, loading, loadPoliticians, isSessionComplete, enrichmentMeta } =
-    useEvaluationSession()
+  const { currentPolitician, loading, isSessionComplete, enrichmentMeta } = useEvaluationSession()
   const { completeBasicTutorial, completeAdvancedTutorial } = useTutorial()
   const { isAdvancedMode } = useUserPreferences()
 
@@ -33,44 +33,61 @@ export default function EvaluatePage() {
     }
   }, [isSessionComplete, router])
 
-  return (
-    <>
-      <Header />
+  // Determine if we're in a loading state (fetching or waiting for enrichment)
+  const isWaitingForData =
+    loading || (enrichmentMeta?.has_enrichable_politicians !== false && !currentPolitician)
 
-      {currentPolitician ? (
+  // All caught up: no politician and nothing left to enrich
+  const isAllCaughtUp =
+    !currentPolitician && !loading && enrichmentMeta?.has_enrichable_politicians === false
+
+  if (currentPolitician) {
+    return (
+      <>
+        <Header />
         <PoliticianEvaluation key={currentPolitician.id} politician={currentPolitician} />
-      ) : (
-        <main className="bg-gray-50 grid place-items-center py-12 px-4 sm:px-6 lg:px-8 min-h-0 overflow-y-auto">
-          <div className="text-center max-w-2xl">
-            {loading || enrichmentMeta?.is_enriching ? (
-              <Loader
-                message={
-                  enrichmentMeta?.is_enriching
-                    ? 'Enriching politician data...'
-                    : 'Loading politician data...'
-                }
-              />
-            ) : (
-              <div className="bg-gray-50 border border-gray-200 rounded-md p-4">
-                <p className="text-gray-600">
-                  No politicians available for your current filters. You can change your{' '}
-                  <Link href="/" className="text-gray-700 hover:text-gray-900 underline">
-                    filters
-                  </Link>
-                  , or{' '}
-                  <button
-                    onClick={loadPoliticians}
-                    className="text-gray-700 hover:text-gray-900 underline cursor-pointer bg-transparent border-0 p-0 font-inherit"
-                  >
-                    reload
-                  </button>
-                  .
-                </p>
-              </div>
-            )}
+      </>
+    )
+  }
+
+  if (isAllCaughtUp) {
+    return (
+      <>
+        <Header />
+        <CenteredCard emoji="🎉" title="You're all caught up!">
+          <p className="mb-6">
+            No more politicians to evaluate for your current filters. Try different filters to
+            continue contributing.
+          </p>
+          <Button href="/" size="large">
+            Start New Session
+          </Button>
+        </CenteredCard>
+      </>
+    )
+  }
+
+  if (isWaitingForData) {
+    return (
+      <>
+        <Header />
+        <CenteredCard emoji="🔍" title="Finding politicians...">
+          <div className="flex justify-center">
+            <Spinner />
           </div>
-        </main>
-      )}
+        </CenteredCard>
+      </>
+    )
+  }
+
+  return (
+    <>
+      <Header />
+      <CenteredCard emoji="🔍" title="Loading...">
+        <div className="flex justify-center">
+          <Spinner />
+        </div>
+      </CenteredCard>
     </>
   )
 }

poliloom-gui/src/contexts/EvaluationSessionContext.tsx

@@ -137,18 +137,18 @@ export function EvaluationSessionProvider({ children }: { children: React.ReactN
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [isAuthenticated, initialized, currentPolitician, loadPoliticians])
 
-  // Auto-poll when no politicians available but enrichment is running
+  // Auto-poll when no politicians available but more can be enriched
   useEffect(() => {
     if (currentPolitician !== null) return
     if (loading) return
-    if (!enrichmentMeta?.is_enriching) return
+    if (!enrichmentMeta?.has_enrichable_politicians) return
 
     const pollInterval = setInterval(() => {
       loadPoliticians()
     }, 5000)
 
     return () => clearInterval(pollInterval)
-  }, [currentPolitician, loading, enrichmentMeta?.is_enriching, loadPoliticians])
+  }, [currentPolitician, loading, enrichmentMeta?.has_enrichable_politicians, loadPoliticians])
 
   const advanceToNextPolitician = useCallback(async () => {
     const newCurrent = nextPolitician

poliloom-gui/src/types/index.ts

@@ -54,7 +54,7 @@ export interface Politician {
 }
 
 export interface EnrichmentMetadata {
-  is_enriching: boolean
+  has_enrichable_politicians: boolean
   total_matching_filters: number
 }
 

poliloom/poliloom/api/evaluations.py

@@ -12,7 +12,11 @@
 from sqlalchemy.orm import Session, selectinload
 
 from ..database import get_db_session
-from ..enrichment import count_politicians_with_unevaluated, enrich_batch
+from ..enrichment import (
+    count_politicians_with_unevaluated,
+    enrich_batch,
+    has_enrichable_politicians,
+)
 from ..models import (
     ArchivedPage,
     ArchivedPageLanguage,
@@ -146,9 +150,11 @@ async def get_politicians_for_evaluation(
     # Track enrichment status for empty state UX
     min_threshold = int(os.getenv("MIN_UNEVALUATED_POLITICIANS", "10"))
     current_count = count_politicians_with_unevaluated(db, languages, countries)
-    is_enriching = False
 
-    if current_count < min_threshold:
+    # Check if there are politicians available to enrich (for "all caught up" state)
+    can_enrich = has_enrichable_politicians(db, languages, countries)
+
+    if current_count < min_threshold and can_enrich:
         logger.info(
             f"Only {current_count} politicians with unevaluated properties (threshold: {min_threshold}), triggering enrichment batch"
         )
@@ -159,7 +165,6 @@ async def get_politicians_for_evaluation(
             languages,
             countries,
         )
-        is_enriching = True
 
     result = []
     for politician in politicians:
@@ -206,7 +211,7 @@ async def get_politicians_for_evaluation(
     return PoliticiansListResponse(
         politicians=result,
         meta=EnrichmentMetadata(
-            is_enriching=is_enriching,
+            has_enrichable_politicians=can_enrich,
             total_matching_filters=current_count,
         ),
     )

poliloom/poliloom/api/schemas.py

@@ -59,7 +59,7 @@ class PoliticianResponse(UUIDBaseModel):
 class EnrichmentMetadata(BaseModel):
     """Metadata about enrichment status for empty state UX."""
 
-    is_enriching: bool = False
+    has_enrichable_politicians: bool = True
     total_matching_filters: int = 0
 
 

poliloom/poliloom/enrichment.py

@@ -647,6 +647,34 @@ def count_politicians_with_unevaluated(
     return result or 0
 
 
+def has_enrichable_politicians(
+    db: Session,
+    languages: Optional[List[str]] = None,
+    countries: Optional[List[str]] = None,
+) -> bool:
+    """
+    Check if there are politicians available to enrich.
+
+    Uses the same query logic as enrich_politician_from_wikipedia to determine
+    if any politicians can be enriched (not enriched within last 6 months).
+
+    Args:
+        db: Database session
+        languages: Optional list of language QIDs to filter by
+        countries: Optional list of country QIDs to filter by
+
+    Returns:
+        True if there are politicians available to enrich, False otherwise
+    """
+    query = Politician.query_for_enrichment(
+        languages=languages,
+        countries=countries,
+    ).limit(1)
+
+    result = db.execute(query).first()
+    return result is not None
+
+
 def enrich_batch(
     languages: Optional[List[str]] = None,
     countries: Optional[List[str]] = None,