Skip to content

Commit fab8299

Browse files
committed
only autodetect language on non-existant key
1 parent 84470b6 commit fab8299

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

poliloom-gui/src/contexts/UserPreferencesContext.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -194,19 +194,19 @@ export function UserPreferencesProvider({ children }: { children: React.ReactNod
194194
loadFromStorage()
195195
}, [])
196196

197-
// Auto-detect browser language on first visit
197+
// Auto-detect browser language on first visit (only if preferences were never set)
198198
useEffect(() => {
199199
if (!initialized || loadingLanguages || languages.length === 0) return
200200

201-
const hasLanguageFilter = filters.some((p) => p.preference_type === PreferenceType.LANGUAGE)
201+
// Only auto-detect if localStorage has never been set
202+
const hasStoredPreferences = localStorage.getItem(FILTERS_STORAGE_KEY) !== null
203+
if (hasStoredPreferences) return
202204

203-
if (!hasLanguageFilter) {
204-
const detectedLanguages = detectBrowserLanguage(languages)
205-
if (detectedLanguages.length > 0) {
206-
updateFilters(PreferenceType.LANGUAGE, detectedLanguages)
207-
}
205+
const detectedLanguages = detectBrowserLanguage(languages)
206+
if (detectedLanguages.length > 0) {
207+
updateFilters(PreferenceType.LANGUAGE, detectedLanguages)
208208
}
209-
}, [initialized, loadingLanguages, languages, filters, updateFilters])
209+
}, [initialized, loadingLanguages, languages, updateFilters])
210210

211211
const value: UserPreferencesContextType = {
212212
filters,

0 commit comments

Comments
 (0)