Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD]Handle data source export #1728

Open
seraphjiang opened this issue Jun 13, 2022 · 5 comments
Open

[MD]Handle data source export #1728

seraphjiang opened this issue Jun 13, 2022 · 5 comments
Labels
enhancement New feature or request multiple datasource multiple datasource project

Comments

@seraphjiang
Copy link
Member

OSD allow users to export saved objects as JSON, need to handle the credential properly (as plain text or hash)

@seraphjiang seraphjiang changed the title Handle data source export [MD]Handle data source export Jun 13, 2022
@kavilla kavilla added the multiple datasource multiple datasource project label Jun 14, 2022
@noCharger noCharger added the v2.5.0 'Issues and PRs related to version v2.5.0' label Oct 5, 2022
@kristenTian
Copy link
Contributor

Dropping the hashed credentials instead.

@zhongnansu zhongnansu removed the v2.5.0 'Issues and PRs related to version v2.5.0' label Nov 8, 2022
@zhongnansu zhongnansu added the enhancement New feature or request label Mar 8, 2023
@vvvprabhakar
Copy link

Any update on this ? I am looking out for this feature, where in i get a export button in my saved objects listing page (Vizs or Dashboards) where user can get saved object json of it and where ever he want he can import and create a same saved object ?

If you need any specific help i am ready for it

@zhongnansu
Copy link
Member

zhongnansu commented Jul 11, 2023

adding a github issue related to this topic. cc: @seraphjiang @zengyan-amazon
#4529

@zhongnansu
Copy link
Member

zhongnansu commented Jul 11, 2023

It's valid use case as @vvvprabhakar mentioned, that we should support export/import data source.
A few things in my mind, if we

  • export password as explicit text: this approach is not secure enough. The user has permission to export may not always be the user that has the permission to the credentials
  • export password as encrypted text (same as how password is saved in index): we need to make code changes, so when import triggers creating data source with encrypted credentials, it won't treat it as a "new" password that needs to be encrypted.

@kgcreative
Copy link
Member

Should data source connections be exportable? It makes me think that endpoint and other information could be, but the credential details should definitely not be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multiple datasource multiple datasource project
Projects
None yet
Development

No branches or pull requests

7 participants