Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Confusing cancel button flow for visualization plugin #3552

Open
abbyhu2000 opened this issue Mar 7, 2023 · 0 comments
Open

[BUG] Confusing cancel button flow for visualization plugin #3552

abbyhu2000 opened this issue Mar 7, 2023 · 0 comments
Labels
bug Something isn't working visualizations Issues and PRs related to visualizations

Comments

@abbyhu2000
Copy link
Member

Describe the bug
As documented in the comments in this PR, #2627, It seems like the original cancel flow for visualization plugin is quite confusing and unnecessarily complicated:

  1. When user create viz from visualization page, no cancel button is shown
  2. When user edit viz from visualization page, no cancel button is shown
  3. When user tries to create viz from dashboard page, cancel button is shown
  4. When user create viz from dashboard with add to dashboard after saving toggle off, then click save. It will direct back to the vis editor page, cancel button is not shown
  5. When user edit viz from dashboard page, cancel button is shown
  6. When user edit viz from dashboard page, made some changes, click save as. Toggle save as new visualization on, and add to dashboard after saving off, cancel button is not shown
  7. When user edit viz from dashboard page, made some changes, click save as. Toggle save as new visualization off, and add to dashboard after saving off, cancel button is shown

I think we should rework and simplify the cancel flow for the visualization plugin so we could have a unified cancel flow throughout the app, ex. vis builder plugin.

One cancel flow can be:

  1. cancel button will not be shown when user creates or edits vis builder from visualization page
  2. cancel button will always be shown when user creates or edits vis builder from the dashboard page.
@abbyhu2000 abbyhu2000 added bug Something isn't working visualizations Issues and PRs related to visualizations labels Mar 7, 2023
@kavilla kavilla removed the untriaged label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working visualizations Issues and PRs related to visualizations
Projects
None yet
Development

No branches or pull requests

2 participants