Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Index pattern service returns inconsistent title #7837

Open
ashwin-pc opened this issue Aug 26, 2024 · 1 comment
Open

[BUG] Index pattern service returns inconsistent title #7837

ashwin-pc opened this issue Aug 26, 2024 · 1 comment
Labels
bug Something isn't working multiple datasource multiple datasource project technical debt If not paid, jeapardizes long-term success and maintainability of the repository.

Comments

@ashwin-pc
Copy link
Member

Describe the bug

The index pattern service updated the cached index pattern title to contain the datasource title in it, but this behaviour is not consistent and calling the get method on the index pattern service shows only the saved object title without the datasource in title. This leads to inconsistent behaviour in the UI.

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.16/src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts#L124-L135

To Reproduce
Steps to reproduce the behavior:

  1. Call indexPatterns.getIdsWithTitle()
  2. Call indexPatterns.get(id) // any id from the previous list
  3. Compare the titles

Expected behavior
Instead of modifying the cache, we shoud store the datasource title as well if we want to avoid another call for the datasource and only append it where we display it to the user. We should ideally never modify the raw title attribute since without it we no longer know what the index pattern title was without making a raw call to the saved object service.

OpenSearch Version
2.16

Dashboards Version
2.16

Plugins

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.

@ashwin-pc ashwin-pc added bug Something isn't working untriaged technical debt If not paid, jeapardizes long-term success and maintainability of the repository. multiple datasource multiple datasource project labels Aug 26, 2024
@opensearch-project opensearch-project deleted a comment Aug 26, 2024
@opensearch-project opensearch-project deleted a comment Aug 26, 2024
@dblock dblock removed the untriaged label Sep 16, 2024
@dblock
Copy link
Member

dblock commented Sep 16, 2024

[Catch All Triage - 1, 2, 3, 4, 5]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working multiple datasource multiple datasource project technical debt If not paid, jeapardizes long-term success and maintainability of the repository.
Projects
None yet
Development

No branches or pull requests

2 participants