Add missing method and test for missing methods

Signed-off-by: Michael Froh <[email protected]>

Author: msfroh

server/src/internalClusterTest/java/org/opensearch/index/mapper/FilterFieldTypeTest.java

@@ -0,0 +1,88 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * The OpenSearch Contributors require contributions made to
+ * this file be licensed under the Apache-2.0 license or a
+ * compatible open source license.
+ */
+
+package org.opensearch.index.mapper;
+
+import org.opensearch.test.OpenSearchTestCase;
+
+import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+
+public class FilterFieldTypeTest extends OpenSearchTestCase {
+
+    private static final class MethodSignature {
+        private final String name;
+        private final Class<?> returnType;
+        private final Class<?>[] parameterTypes;
+
+        public MethodSignature(String name, Class<?> returnType, Class<?>[] parameterTypes) {
+            this.name = name;
+            this.returnType = returnType;
+            this.parameterTypes = parameterTypes;
+        }
+
+        @Override
+        public boolean equals(Object o) {
+            if (o == null || getClass() != o.getClass()) return false;
+            MethodSignature that = (MethodSignature) o;
+            return Objects.equals(name, that.name)
+                && Objects.equals(returnType, that.returnType)
+                && Objects.deepEquals(parameterTypes, that.parameterTypes);
+        }
+
+        @Override
+        public int hashCode() {
+            return Objects.hash(name, returnType, Arrays.hashCode(parameterTypes));
+        }
+    }
+
+    private static final Set<MethodSignature> EXCLUDED_SIGNATURES = Set.of(new MethodSignature("typeName", String.class, new Class<?>[0]));
+
+    public void testAllMethodsDelegated() {
+        Method[] mappedFieldTypeMethods = MappedFieldType.class.getMethods();
+        Method[] filterFieldTypeMethods = FilterFieldType.class.getMethods();
+
+        Set<MethodSignature> mappedFieldTypeMethodSignatures = new HashSet<>();
+        for (Method method : mappedFieldTypeMethods) {
+            if (method.getDeclaringClass() == MappedFieldType.class
+                && Modifier.isFinal(method.getModifiers()) == false
+                && Modifier.isStatic(method.getModifiers()) == false) {
+                mappedFieldTypeMethodSignatures.add(
+                    new MethodSignature(method.getName(), method.getReturnType(), method.getParameterTypes())
+                );
+            }
+        }
+
+        Set<MethodSignature> filterFieldTypeMethodSignatures = new HashSet<>();
+        for (Method method : filterFieldTypeMethods) {
+            if (method.getDeclaringClass() == FilterFieldType.class) {
+                filterFieldTypeMethodSignatures.add(
+                    new MethodSignature(method.getName(), method.getReturnType(), method.getParameterTypes())
+                );
+            }
+        }
+        for (MethodSignature methodSignature : mappedFieldTypeMethodSignatures) {
+            if (filterFieldTypeMethodSignatures.contains(methodSignature)) {
+                assertFalse(
+                    "Method " + methodSignature.name + " should NOT be implemented in " + FilterFieldType.class.getSimpleName(),
+                    EXCLUDED_SIGNATURES.contains(methodSignature)
+                );
+            } else {
+                assertTrue(
+                    "Method " + methodSignature.name + " should be implemented in " + FilterFieldType.class.getSimpleName(),
+                    EXCLUDED_SIGNATURES.contains(methodSignature)
+                );
+            }
+        }
+    }
+
+}

server/src/main/java/org/opensearch/index/mapper/FilterFieldType.java

@@ -19,6 +19,7 @@
 import org.opensearch.common.time.DateMathParser;
 import org.opensearch.common.unit.Fuzziness;
 import org.opensearch.index.analysis.NamedAnalyzer;
+import org.opensearch.index.fielddata.IndexFieldData;
 import org.opensearch.index.query.IntervalMode;
 import org.opensearch.index.query.QueryRewriteContext;
 import org.opensearch.index.query.QueryShardContext;
@@ -30,6 +31,7 @@
 import java.util.List;
 import java.util.Map;
 import java.util.function.Function;
+import java.util.function.Supplier;
 
 public abstract class FilterFieldType<T extends MappedFieldType> extends MappedFieldType {
     protected final T delegate;
@@ -271,6 +273,11 @@ public TextSearchInfo getTextSearchInfo() {
         return delegate.getTextSearchInfo();
     }
 
+    @Override
+    public IndexFieldData.Builder fielddataBuilder(String fullyQualifiedIndexName, Supplier<SearchLookup> searchLookup) {
+        return delegate.fielddataBuilder(fullyQualifiedIndexName, searchLookup);
+    }
+
     @Override
     public MappedFieldType unwrap() {
         return delegate.unwrap();