Skip to content

Commit b085ebd

Browse files
committed
fixed split_index e2e test
Signed-off-by: Vaibhav Agarwal <[email protected]>
1 parent 8aae13f commit b085ebd

File tree

1 file changed

+49
-53
lines changed

1 file changed

+49
-53
lines changed

cypress/e2e/plugins/index-management-dashboards-plugin/split_index.js

+49-53
Original file line numberDiff line numberDiff line change
@@ -29,160 +29,156 @@ describe("Split Index", () => {
2929
cy.contains("Create index");
3030

3131
// type field name
32-
cy.get('[placeholder="Specify a name for the new index."]').type(sampleIndex).end();
32+
cy.get('[placeholder="Specify a name for the new index."]').type(sampleIndex);
3333

34-
cy.get('[data-test-subj="comboBoxSearchInput"]').focus().type(`${sampleAlias}`).end();
34+
cy.get('[data-test-subj="comboBoxSearchInput"]').focus().type(`${sampleAlias}`);
3535

3636
// click create
37-
cy.get('[data-test-subj="createIndexCreateButton"]').click({ force: true }).end();
37+
cy.get('[data-test-subj="createIndexCreateButton"]').click({ force: true });
3838

3939
// The index should exist
40-
cy.get(`#_selection_column_${sampleIndex}-checkbox`).should("have.exist").end();
40+
cy.get(`#_selection_column_${sampleIndex}-checkbox`).should("have.exist");
4141

42-
cy.get(`[data-test-subj="viewIndexDetailButton-${sampleIndex}"]`).click().end();
43-
cy.get("#indexDetailModalSettings").click().end();
42+
cy.get(`[data-test-subj="viewIndexDetailButton-${sampleIndex}"]`).click();
43+
cy.get("#indexDetailModalSettings", { timeout: 10000 }).click();
4444

4545
cy.get('[data-test-subj="form-name-index.number_of_shards"] .euiText').then(($shardNumber) => {
4646
splitNumber = $shardNumber.attr("title") * 2;
4747
});
4848

49-
cy.get("#indexDetailModalAlias").click().end();
50-
cy.get(`[title="${sampleAlias}"]`).should("exist").end();
49+
cy.get("#indexDetailModalAlias").click();
50+
cy.get(`[title="${sampleAlias}"]`).should("exist");
5151

5252
// Update Index status to blocks write otherwise we can't apply split operation on it
5353
cy.updateIndexSettings(sampleIndex, {
5454
"index.blocks.write": "true",
55-
}).end();
55+
});
5656
}); // create index
5757

5858
it("Split successfully", () => {
5959
const targetIndex = `${sampleIndex}` + "-target";
6060
cy.get(`[data-test-subj="checkboxSelectRow-${sampleIndex}"]`)
6161
.click()
62-
.end()
62+
6363
.get('[data-test-subj="moreAction"]')
6464
.click()
65-
.end()
65+
6666
.get('[data-test-subj="Split Action"]')
6767
.click()
68-
.end()
68+
6969
// Target Index Name is required
7070
.get('[data-test-subj="targetIndexNameInput"]')
7171
.type(`${targetIndex}`)
72-
.end()
72+
7373
// Number of shards after split is required
7474
.get('[data-test-subj="numberOfShardsInput"]')
7575
.type(`${splitNumber}{downArrow}{enter}`)
76-
.end()
76+
7777
.get('[data-test-subj="numberOfReplicasInput"]')
7878
.clear()
7979
.type(`${replicaNumber}`)
80-
.end()
80+
8181
.get('[data-test-subj="splitButton"]', { timeout: 8000 })
82-
.click()
83-
.end();
82+
.click();
8483

85-
cy.get(`[data-test-subj="viewIndexDetailButton-${targetIndex}"]`).click().end();
86-
cy.get("#indexDetailModalSettings").click().end();
87-
cy.get('[data-test-subj="form-name-index.number_of_shards"] .euiText').should("have.text", `${splitNumber}`).end();
88-
cy.get('[data-test-subj="form-name-index.number_of_replicas"] input').should("have.value", `${replicaNumber}`).end();
84+
cy.get(`[data-test-subj="viewIndexDetailButton-${targetIndex}"]`).click();
85+
cy.get("#indexDetailModalSettings", { timeout: 10000 }).click();
86+
cy.get('[data-test-subj="form-name-index.number_of_shards"] .euiText').should("have.text", `${splitNumber}`);
87+
cy.get('[data-test-subj="form-name-index.number_of_replicas"] input').should("have.value", `${replicaNumber}`);
8988
}); // Split
9089

9190
it("Split successfully with advanced setting", () => {
9291
const targetIndex = `${sampleIndex}` + "-setting";
9392
cy.get(`[data-test-subj="checkboxSelectRow-${sampleIndex}"]`)
9493
.click()
95-
.end()
94+
9695
.get('[data-test-subj="moreAction"]')
9796
.click()
98-
.end()
97+
9998
.get('[data-test-subj="Split Action"]')
10099
.click()
101-
.end()
100+
102101
.get("[data-test-subj=targetIndexNameInput]")
103102
.type(`${targetIndex}`)
104-
.end()
103+
105104
// Instead of input shard number at shard field, another option is to populate it in advanced setting
106105
.get('[aria-controls="accordionForCreateIndexSettings"]')
107106
.click()
108-
.end()
107+
109108
.get('[data-test-subj="codeEditorContainer"] textarea')
110109
.focus()
111110
// Need to remove the default {} in advanced setting
112111
.clear()
113112
.type(`{"index.number_of_shards": "${splitNumber}", "index.number_of_replicas": "${replicaNumber}"}`, {
114113
parseSpecialCharSequences: false,
115114
})
116-
.end()
115+
117116
.get('[data-test-subj="splitButton"]', { timeout: 8000 })
118-
.click()
119-
.end();
117+
.click();
120118

121-
cy.get(`[data-test-subj="viewIndexDetailButton-${targetIndex}"]`).click().end();
122-
cy.get("#indexDetailModalSettings").click().end();
123-
cy.get('[data-test-subj="form-name-index.number_of_shards"] .euiText').should("have.text", `${splitNumber}`).end();
124-
cy.get('[data-test-subj="form-name-index.number_of_replicas"] input').should("have.value", `${replicaNumber}`).end();
119+
cy.get(`[data-test-subj="viewIndexDetailButton-${targetIndex}"]`).click();
120+
cy.get("#indexDetailModalSettings", { timeout: 10000 }).click();
121+
cy.get('[data-test-subj="form-name-index.number_of_shards"] .euiText').should("have.text", `${splitNumber}`);
122+
cy.get('[data-test-subj="form-name-index.number_of_replicas"] input').should("have.value", `${replicaNumber}`);
125123
}); // advanced setting
126124

127125
it("Split successfully with alias", () => {
128126
const targetIndex = `${sampleIndex}` + "-alias";
129127
const newAlias = "alias-new";
130128
cy.get(`[data-test-subj="checkboxSelectRow-${sampleIndex}"]`)
131129
.click()
132-
.end()
130+
133131
.get('[data-test-subj="moreAction"]')
134132
.click()
135-
.end()
133+
136134
.get('[data-test-subj="Split Action"]')
137135
.click()
138-
.end()
136+
139137
.get("[data-test-subj=targetIndexNameInput]")
140138
.type(`${targetIndex}`)
141-
.end()
139+
142140
.get('[data-test-subj="numberOfShardsInput"]')
143141
.type(`${splitNumber}{downArrow}{enter}`)
144-
.end()
142+
145143
// Assign to an existing alias and a new alias
146144
.get('[data-test-subj="form-name-aliases"] [data-test-subj="comboBoxSearchInput"]')
147145
.type(`${sampleAlias}{enter}${newAlias}{enter}`)
148-
.end()
146+
149147
.get('[data-test-subj="splitButton"]', { timeout: 8000 })
150-
.click()
151-
.end();
148+
.click();
152149

153-
cy.get(`[data-test-subj="viewIndexDetailButton-${targetIndex}"]`).click().end();
150+
cy.get(`[data-test-subj="viewIndexDetailButton-${targetIndex}"]`).click();
154151
// Verify alias associated with the new index
155-
cy.get("#indexDetailModalAlias").click().end();
156-
cy.get(`[title="${newAlias}"]`).should("exist").end();
157-
cy.get(`[title="${sampleAlias}"]`).should("exist").end();
152+
cy.get("#indexDetailModalAlias").click();
153+
cy.get(`[title="${newAlias}"]`).should("exist");
154+
cy.get(`[title="${sampleAlias}"]`).should("exist");
158155
}); // Create with alias
159156

160157
it("Update blocks write to true", () => {
161158
// Set index to not blocks write
162159
cy.updateIndexSettings(sampleIndex, {
163160
"index.blocks.write": "false",
164-
}).end();
161+
});
165162
cy.get(`[data-test-subj="checkboxSelectRow-${sampleIndex}"]`)
166163
.click()
167-
.end()
164+
168165
.get('[data-test-subj="moreAction"]')
169166
.click()
170-
.end()
167+
171168
.get('[data-test-subj="Split Action"]')
172169
.click()
173-
.end()
170+
174171
// Index can't be split if it's blocks write status is not true
175172
.get('[data-test-subj="splitButton"]', { timeout: 8000 })
176173
.should("have.class", "euiButton-isDisabled")
177-
.end()
174+
178175
.wait(1000)
179176
// Set index to blocks write
180177
.get('[data-test-subj="set-indexsetting-button"]', { timeout: 8000 })
181178
.click()
182-
.end()
179+
183180
.get('[data-test-subj="splitButton"]', { timeout: 8000 })
184-
.click()
185-
.end();
181+
.click();
186182
}); // Blocks write
187183
});
188184
});

0 commit comments

Comments
 (0)