diff --git a/common/src/main/java/org/opensearch/ml/common/settings/MLCommonsSettings.java b/common/src/main/java/org/opensearch/ml/common/settings/MLCommonsSettings.java index 39775a4e8a..c139ea4b68 100644 --- a/common/src/main/java/org/opensearch/ml/common/settings/MLCommonsSettings.java +++ b/common/src/main/java/org/opensearch/ml/common/settings/MLCommonsSettings.java @@ -339,7 +339,7 @@ private MLCommonsSettings() {} // Feature flag for execute tool API public static final Setting ML_COMMONS_EXECUTE_TOOL_ENABLED = Setting - .boolSetting(ML_PLUGIN_SETTING_PREFIX + "execute_tools_enabled", false, Setting.Property.NodeScope, Setting.Property.Dynamic); + .boolSetting(ML_PLUGIN_SETTING_PREFIX + "execute_tools_enabled", true, Setting.Property.NodeScope, Setting.Property.Dynamic); public static final String ML_COMMONS_EXECUTE_TOOL_DISABLED_MESSAGE = "The Execute Tool API is not enabled. To enable, please update the setting " + ML_COMMONS_EXECUTE_TOOL_ENABLED.getKey(); diff --git a/plugin/src/test/java/org/opensearch/ml/settings/MLFeatureEnabledSettingTests.java b/plugin/src/test/java/org/opensearch/ml/settings/MLFeatureEnabledSettingTests.java index a86ed97ba1..f27e71e8bc 100644 --- a/plugin/src/test/java/org/opensearch/ml/settings/MLFeatureEnabledSettingTests.java +++ b/plugin/src/test/java/org/opensearch/ml/settings/MLFeatureEnabledSettingTests.java @@ -125,16 +125,16 @@ public void testMetricCollectionSettings() { @Test public void testToolExecuteSettings() { // Test initial values - assertFalse(mlFeatureEnabledSetting.isToolExecuteEnabled()); + assertTrue(mlFeatureEnabledSetting.isToolExecuteEnabled()); // Simulate settings change - Settings newSettings = Settings.builder().put(ML_COMMONS_EXECUTE_TOOL_ENABLED.getKey(), true).build(); + Settings newSettings = Settings.builder().put(ML_COMMONS_EXECUTE_TOOL_ENABLED.getKey(), false).build(); // Update settings through cluster service when(clusterService.getSettings()).thenReturn(newSettings); mlFeatureEnabledSetting = new MLFeatureEnabledSetting(clusterService, newSettings); // Verify updated values - assertTrue(mlFeatureEnabledSetting.isToolExecuteEnabled()); + assertFalse(mlFeatureEnabledSetting.isToolExecuteEnabled()); } } diff --git a/release-notes/opensearch-ml-common.release-notes-3.3.0.0.md b/release-notes/opensearch-ml-common.release-notes-3.3.0.0.md index 4b5d9f8f54..7e13ad2aae 100644 --- a/release-notes/opensearch-ml-common.release-notes-3.3.0.0.md +++ b/release-notes/opensearch-ml-common.release-notes-3.3.0.0.md @@ -36,6 +36,7 @@ Compatible with OpenSearch and OpenSearch Dashboards version 3.3.0 * [Agentic Search] Use same model for Agent and QPT ([#4262](https://github.com/opensearch-project/ml-commons/pull/4262)) * Improve semantic fact extraction prompt and add JSON enforcement ([#4282](https://github.com/opensearch-project/ml-commons/pull/4282)) * Improve user preference extraction prompt with XML-based structure ([#4288](https://github.com/opensearch-project/ml-commons/pull/4288)) +* Enable execute tool feature flag by default ([#4296](https://github.com/opensearch-project/ml-commons/pull/4296)) ### Bug Fixes * Fix NPE when execute flow agent with mutli tenancy is off ([#4189](https://github.com/opensearch-project/ml-commons/pull/4189)) @@ -65,6 +66,8 @@ Compatible with OpenSearch and OpenSearch Dashboards version 3.3.0 * Fix agent streaming with security enabled + error handling ([#4256](https://github.com/opensearch-project/ml-commons/pull/4256)) * Fix llm result path; convert message to user prompt string ([#4283](https://github.com/opensearch-project/ml-commons/pull/4283)) * Fix llm result path error ([#4292](https://github.com/opensearch-project/ml-commons/pull/4292)) +* Fix dimension update flow to allow embedding type update ([#4297](https://github.com/opensearch-project/ml-commons/pull/4297)) +* Verify llm before summarize session ([#4300](https://github.com/opensearch-project/ml-commons/pull/4300)) ### Infrastructure * Update maintainer list ([#4139](https://github.com/opensearch-project/ml-commons/pull/4139))