fix: resolve TOCTOU race condition in daily forecaster chart control click (#2127) (#2128)

(cherry picked from commit 31219c6)

Signed-off-by: shreyah963 <shreyab963@gmail.com>
Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Shreya Bhatta <shreyab963@gmail.com>

Author: opensearch-ci-bot

cypress/integration/plugins/anomaly-detection-dashboards-plugin/daily_forecaster_spec.js

@@ -36,13 +36,16 @@ const clickControlAndVerifyChartUpdate = (buttonAriaLabel) => {
       cy.get('.echChartStatus')
         .invoke('attr', 'data-ech-render-count')
         .then((initialRenderCount) => {
-          cy.get(`button[aria-label="${buttonAriaLabel}"]`).click();
-
-          // Cypress's .should() will automatically retry until the assertion passes or times out,
-          // which handles the async nature of the re-render.
-          cy.get('.echChartStatus')
-            .invoke('attr', 'data-ech-render-count')
-            .should('not.eq', initialRenderCount);
+          // Re-check disabled state right before clicking to avoid TOCTOU race
+          cy.get(`button[aria-label="${buttonAriaLabel}"]`).then(($btn) => {
+            if (!$btn.is(':disabled')) {
+              cy.wrap($btn).click();
+
+              cy.get('.echChartStatus')
+                .invoke('attr', 'data-ech-render-count')
+                .should('not.eq', initialRenderCount);
+            }
+          });
         });
     }
   });