Skip to content

Commit 9a6c083

Browse files
TackAdamAdam Tackett
andauthored
Fix mocha version collision breaking Cypress reporters (#2073)
* fix obs test failures: pin mocha to Cypress bundled version The CVE-fix commit (#2068) migrated this repo from yarn to npm. Under npm, the reporters' mocha peerDependency auto-installs a top-level mocha@11, which conflicts with Cypress 13.17's bundled mocha@7.0.1 and breaks the reporter (test.slow is not a function). Pin mocha to 7.0.1 via overrides so both cypress-multi-reporters and mocha-junit-reporter resolve against the same mocha Cypress runs. Lockfile is updated incrementally from the working main lockfile so it stays in sync (npm ci) and keeps ajv@8.20.0 top-level with eslint's nested ajv@6.15.0 (lint passes). Signed-off-by: Adam Tackett <tackadam@amazon.com> * Pin dorny/paths-filter to commit SHA in dashboard-variable workflow This workflow was missed in c791b5b (Pin GitHub Actions to commit SHAs). The org policy rejects unpinned actions, failing the 'changes' job. Use the same SHA (4512585405083f25c027a35db413c2b3b9006d50 # v2) already used by the other 20 e2e workflows. Signed-off-by: Adam Tackett <tackadam@amazon.com> --------- Signed-off-by: Adam Tackett <tackadam@amazon.com> Co-authored-by: Adam Tackett <tackadam@amazon.com>
1 parent 19a1a53 commit 9a6c083

3 files changed

Lines changed: 905 additions & 426 deletions

File tree

.github/workflows/dashboard-variable-release-e2e-workflow.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
outputs:
1010
tests: ${{ steps.filter.outputs.tests }}
1111
steps:
12-
- uses: dorny/paths-filter@v2
12+
- uses: dorny/paths-filter@4512585405083f25c027a35db413c2b3b9006d50 # v2
1313
id: filter
1414
with:
1515
filters: |

0 commit comments

Comments
 (0)